Skip to content

fix(edit): show candidate lines with similarity scores on oldText match failure #97038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincentkoc merged 3 commits into from
Jul 6, 2026
Merged

fix(edit): show candidate lines with similarity scores on oldText match failure #97038

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0c2c48
fix(edit): show candidate lines on oldText match failure
ZOOWH Jun 26, 2026
4ff02ab
fix(edit): use toSorted instead of sort for candidate ranking
ZOOWH Jun 26, 2026
59b8f92
fix(edit): keep candidate truncation branch-compatible
vincentkoc Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(edit): use toSorted instead of sort for candidate ranking 
Fixes lint violation: unicorn(no-array-sort)
  • Loading branch information
@ZOOWH @vincentkoc
ZOOWH authored and vincentkoc committed Jul 6, 2026
commit 4ff02abb971d8daaa0a0d4eb8e9308da0c254a23
2 changes: 1 addition & 1 deletion src/agents/sessions/tools/edit-diff.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ function getNotFoundError(
return { lineNum: idx + 1, line: trimmed, score: maxLen > 0 ? 1 - dist / maxLen : 0 };
})
.filter((s) => s.score > 0.3)
.sort((a, b) => b.score - a.score)
.toSorted((a, b) => b.score - a.score)
.slice(0, 3);
if (scored.length > 0) {
hint =
Expand Down