fix(googlechat): truncate approval card text on UTF-16 boundary by WeeLi-009 · Pull Request #96573 · openclaw/openclaw

WeeLi-009 · 2026-06-24T22:26:59Z

Summary: Google Chat approval-card text was truncated with a raw UTF-16 slice, so an emoji near the limit became a lone surrogate in the cardsV2 API payload. This uses truncateUtf16Safe to truncate on a code-point boundary.

What Problem This Solves

Google Chat approval cards truncated long text by UTF-16 code unit length. When the truncation boundary landed inside an astral character, such as a command containing 1796 a characters followed by 😀, the old raw .slice() behavior kept only the high surrogate (0xd83d) before appending ....

That produced ill-formed UTF-16 in the Google Chat card text. The terminal proof below reproduces the old boundary with raw .slice() and shows encodeURIComponent rejecting the result with URIError: URI malformed.

Fix

extensions/googlechat/src/approval-handler.runtime.ts now routes Google Chat approval text truncation through the shared truncateUtf16Safe helper before appending the suffix.

The helper clamps and floors the requested length, slices through the shared UTF-16-safe path, and adjusts slice edges away from dangling high/low surrogate halves. Google Chat still escapes plain command/card text after truncation, so the final card text remains both HTML-escaped and UTF-16 well formed.

Evidence

The demo imports the real Google Chat approval runtime from extensions/googlechat/src/approval-handler.runtime.ts and calls googleChatApprovalNativeRuntime.presentation.buildPendingPayload with an emoji/surrogate-boundary command. The BEFORE section uses the old raw .slice() shape for comparison; the AFTER section reads the actual fixed Google Chat card text.

Command:

node --import tsx demo.mts

Output:

input.length 1898
emoji boundary codePointAt(1796) 0x1f600
BEFORE raw slice length 1800
BEFORE codePointAt(1796) 0xd83d
BEFORE lone-surrogate-hex 0xd83d
BEFORE lone-surrogate true
BEFORE encodeURIComponent URIError: URI malformed
AFTER source googleChatApprovalNativeRuntime.presentation.buildPendingPayload
AFTER fixed card text length 1799
AFTER tail "aaaaa..."
AFTER codePointAt(1796) 0x2e
AFTER lone-surrogate-hex none
AFTER lone-surrogate false
AFTER encodeURIComponent aaaaaaaaa...

The fixed runtime output has lone-surrogate false, no dangling surrogate hex value, and survives URI encoding, so the Google Chat approval card text is well formed at the emoji truncation boundary.

Tests

Vitest regression coverage in extensions/googlechat/src/approval-handler.runtime.test.ts covers the red/green behavior for Google Chat approval card truncation:

keeps truncated pending command card text UTF-16 well formed covers the exact boundary where raw truncation would leave \ud83d.
preserves a complete astral character when it fits before the truncation suffix covers the adjacent case where the complete emoji should be retained before ....

clawsweeper · 2026-06-24T22:27:59Z

Codex review: needs maintainer review before merge. Reviewed June 26, 2026, 2:08 AM ET / 06:08 UTC.

Summary
The PR updates Google Chat approval-card truncation to use the shared UTF-16-safe helper and adds regression tests for emoji/surrogate boundaries.

PR surface: Source +1, Tests +64. Total +65 across 2 files.

Reproducibility: yes. Source inspection shows current main and v2026.6.10 truncate Google Chat card text with raw slice, and the PR body includes terminal output demonstrating the old surrogate split and after-fix well-formed output.

Review metrics: none identified.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🦞 diamond lobster
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

none.

Mantis proof suggestion
A visible Google Chat card proof would add useful transport-level confidence for the rendered approval card, although terminal proof already covers the string boundary. A maintainer can ask Mantis to capture proof by posting this exact PR comment:

@openclaw-mantis visual task: verify a Google Chat approval card with an emoji at the truncation boundary renders without malformed text and keeps approval buttons usable.

Next step before merge

No automated repair target is needed; a maintainer should do the normal final review and decide whether optional live Google Chat visual proof is worth requesting.

Security
Cleared: No concrete security or supply-chain concern was found; the diff imports an existing SDK helper and adds focused tests without touching secrets, dependencies, workflows, or publishing paths.

Review details

Best possible solution:

Land the focused Google Chat truncation fix after normal maintainer review, keeping the change at the existing card-text formatting boundary and shared SDK helper.

Do we have a high-confidence way to reproduce the issue?

Yes. Source inspection shows current main and v2026.6.10 truncate Google Chat card text with raw slice, and the PR body includes terminal output demonstrating the old surrogate split and after-fix well-formed output.

Is this the best way to solve the issue?

Yes. Reusing truncateUtf16Safe in the existing Google Chat truncateText helper is the narrowest maintainable fix because it preserves the current length budget, suffix, escaping flow, and plugin SDK boundary.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 4fc504d321b6.

Label changes

Label justifications:

P2: This fixes a channel-specific approval-card correctness bug with limited blast radius and clear regression coverage.
rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🦞 diamond lobster and patch quality is 🐚 platinum hermit.
status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (terminal): The PR body includes terminal output from a demo importing the real Google Chat approval runtime and showing after-fix card text has no lone surrogate and survives URI encoding.
proof: sufficient: Contributor real behavior proof is sufficient. The PR body includes terminal output from a demo importing the real Google Chat approval runtime and showing after-fix card text has no lone surrogate and survives URI encoding.

Evidence reviewed

PR surface:

Source +1, Tests +64. Total +65 across 2 files.

View PR surface stats

Area	Files	Added	Removed	Net
Source	1	2	1	+1
Tests	1	64	0	+64
Docs	0	0	0	0
Config	0	0	0	0
Generated	0	0	0	0
Other	0	0	0	0
Total	2	66	1	+65

What I checked:

Repository policy read: Root AGENTS.md and scoped extensions/AGENTS.md were read; the scoped plugin policy allows bundled plugin code to import through openclaw/plugin-sdk/*, which matches this PR's helper import. (extensions/AGENTS.md:1, 4fc504d321b6)
Current main still has raw slicing: The current main Google Chat approval-card truncation helper slices with text.slice(0, maxChars - 3), so the central bug is not already fixed on main. (extensions/googlechat/src/approval-handler.runtime.ts:90, 4fc504d321b6)
Latest release still has raw slicing: The latest release tag v2026.6.10 contains the same raw slice implementation, so the fix has not already shipped. (extensions/googlechat/src/approval-handler.runtime.ts:90, aa69b12d0086)
PR head uses shared safe helper: The PR replaces the raw slice with truncateUtf16Safe(text, maxChars - 3) inside the existing Google Chat truncateText helper, preserving the existing suffix and card-text boundary. (extensions/googlechat/src/approval-handler.runtime.ts:91, acb274873847)
Shared helper contract: truncateUtf16Safe clamps/floors the limit and delegates to sliceUtf16Safe, which moves slice edges away from dangling surrogate halves. (src/utils.ts:111, 4fc504d321b6)
Regression tests cover the boundary: The PR adds tests for the exact split-surrogate boundary and the adjacent complete-astral-character case in the Google Chat approval runtime tests. (extensions/googlechat/src/approval-handler.runtime.test.ts:191, acb274873847)

Likely related people:

kevinslin: Merged PR metadata shows this person authored and merged the Google Chat native approval-card runtime that contains the affected truncation helper. (role: introduced behavior; confidence: high; commits: e187c3b7068d, 5923f2af4620; files: extensions/googlechat/src/approval-handler.runtime.ts, extensions/googlechat/src/approval-handler.runtime.test.ts)
Peter Steinberger: Git history shows this person introduced the shared UTF-16-safe truncation utility that the PR reuses. (role: adjacent utility owner; confidence: medium; commits: 63f5fa47deb6; files: src/utils.ts)
zhang-guiping: Current blame for the Google Chat truncate helper and shared UTF-16 helper points to a broad recent commit carrying these files into current main; the commit scope makes ownership confidence low. (role: recent area contributor; confidence: low; commits: bead84f0ee6e; files: extensions/googlechat/src/approval-handler.runtime.ts, extensions/googlechat/src/approval-handler.runtime.test.ts, src/utils.ts)

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

truncateText sliced the approval card text paragraph with String.slice, which can cut through an astral character's surrogate pair (e.g. an emoji straddling the 1797-char limit), leaving a lone surrogate in the card text sent to Google Chat. Use truncateUtf16Safe from the plugin SDK so truncation never splits a surrogate pair, keeping the '...' suffix and the existing length budget. Adds tests asserting the truncated Command card text stays UTF-16 well formed and that an astral character is preserved when it fits.

…claw#96573) truncateText sliced the approval card text paragraph with String.slice, which can cut through an astral character's surrogate pair (e.g. an emoji straddling the 1797-char limit), leaving a lone surrogate in the card text sent to Google Chat. Use truncateUtf16Safe from the plugin SDK so truncation never splits a surrogate pair, keeping the '...' suffix and the existing length budget. Adds tests asserting the truncated Command card text stays UTF-16 well formed and that an astral character is preserved when it fits.

…claw#96573) truncateText sliced the approval card text paragraph with String.slice, which can cut through an astral character's surrogate pair (e.g. an emoji straddling the 1797-char limit), leaving a lone surrogate in the card text sent to Google Chat. Use truncateUtf16Safe from the plugin SDK so truncation never splits a surrogate pair, keeping the '...' suffix and the existing length budget. Adds tests asserting the truncated Command card text stays UTF-16 well formed and that an astral character is preserved when it fits. (cherry picked from commit 2e881ab)

…claw#96573) truncateText sliced the approval card text paragraph with String.slice, which can cut through an astral character's surrogate pair (e.g. an emoji straddling the 1797-char limit), leaving a lone surrogate in the card text sent to Google Chat. Use truncateUtf16Safe from the plugin SDK so truncation never splits a surrogate pair, keeping the '...' suffix and the existing length budget. Adds tests asserting the truncated Command card text stays UTF-16 well formed and that an astral character is preserved when it fits.

openclaw-barnacle Bot added channel: googlechat Channel integration: googlechat size: S triage: needs-pr-context Candidate: external PR body lacks required problem context or evidence. labels Jun 24, 2026

WeeLi-009 force-pushed the fix/googlechat-truncate-surrogate branch from 7ac6010 to acb2748 Compare June 25, 2026 04:17

openclaw-barnacle Bot removed the triage: needs-pr-context Candidate: external PR body lacks required problem context or evidence. label Jun 25, 2026

github-actions Bot mentioned this pull request Jun 26, 2026

🦞 OpenClaw 生态日报 2026-06-26 96loveslife/big_model_radar#60

Open

vincentkoc merged commit 2e881ab into openclaw:main Jun 27, 2026
119 of 128 checks passed

github-actions Bot mentioned this pull request Jun 27, 2026

📡 Upstream Digest — 2026-06-27 16:59 UTC curtismercier/openclaw-mods#1160

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(googlechat): truncate approval card text on UTF-16 boundary#96573

fix(googlechat): truncate approval card text on UTF-16 boundary#96573
vincentkoc merged 1 commit into
openclaw:mainfrom
WeeLi-009:fix/googlechat-truncate-surrogate

WeeLi-009 commented Jun 24, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented Jun 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

WeeLi-009 commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Problem This Solves

Fix

Evidence

Tests

Uh oh!

clawsweeper Bot commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

WeeLi-009 commented Jun 24, 2026 •

edited

Loading

clawsweeper Bot commented Jun 24, 2026 •

edited

Loading