Skip to content

fix(terminal-core): tighten docs link URL detection #96439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincentkoc merged 2 commits into from
Jun 29, 2026
+13 −1
Merged

fix(terminal-core): tighten docs link URL detection #96439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64cf193
fix(terminal-core): tighten docs link URL detection
lin-hongkuan Jun 24, 2026
d5ff562
chore: retrigger PR checks
lin-hongkuan Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/terminal-core/src/links.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,16 @@ describe("formatDocsLink", () => {
expect(out).toBe("https://example.com/page");
});

it("preserves uppercase absolute HTTPS urls", () => {
const out = formatDocsLink("HTTPS://example.com/page", "page");
expect(out).toBe("HTTPS://example.com/page");
});

it("does not treat http-prefixed relative paths as absolute urls", () => {
const out = formatDocsLink("http-status", "HTTP status");
expect(out).toBe("https://docs.openclaw.ai/http-status");
});

it("treats whitespace-only path like an empty path and falls back to docs root", () => {
const out = formatDocsLink(" ", "root");
expect(out).toBe("https://docs.openclaw.ai");
Expand Down
4 changes: 3 additions & 1 deletion packages/terminal-core/src/links.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ function resolveDocsRoot(): string {
return "https://docs.openclaw.ai";
}

const ABSOLUTE_HTTP_URL_RE = /^https?:\/\//i;

export function formatDocsLink(
path: string | undefined | null,
label?: string,
Expand All @@ -17,7 +19,7 @@ export function formatDocsLink(
// here unguarded. The typed contract says docsPath is required, but a
// handful of channel plugins and catalog rows leave it unset at runtime.
const url = trimmed
? trimmed.startsWith("http")
? ABSOLUTE_HTTP_URL_RE.test(trimmed)
? trimmed
: `${docsRoot}${trimmed.startsWith("/") ? trimmed : `/${trimmed}`}`
: docsRoot;
Expand Down
Loading