Skip to content

test(ui): bound chat hover browser wait#105133

Merged
steipete merged 1 commit into
release/2026.7.1from
codex/beta-chat-hover-timeout
Jul 12, 2026
Merged

test(ui): bound chat hover browser wait#105133
steipete merged 1 commit into
release/2026.7.1from
codex/beta-chat-hover-timeout

Conversation

@steipete

Copy link
Copy Markdown
Contributor

Summary

  • Gives the timestamp-hover browser regression its own 20-second test budget.
  • Keeps every existing hover, layout, and click assertion unchanged.
  • Prevents the outer Vitest default from expiring before the test's existing 10-second browser wait.

Linked context

Requested as part of July beta release validation cleanup.

Real behavior proof (required for external PRs)

  • Behavior or issue addressed: the browser test timed out at the default 5 seconds while its inner element wait permits 10 seconds.
  • Real environment tested: Blacksmith Testbox Chromium run.
  • Exact steps or command run after this patch: focused pnpm test ui/src/pages/chat/chat-responsive.browser.test.ts through the repository Crabbox wrapper.
  • Evidence after fix: 55/55 tests passed; the affected case passed in 1.529 seconds.
  • Observed result after fix: the browser contract remains fully asserted with a bounded outer timeout.
  • What was not tested: full beta validation is running separately.
  • Proof limitations or environment constraints: Tahoe remains stopped; no macOS proof was run.
  • Before evidence: https://github.com/openclaw/openclaw/actions/runs/29184485559/job/86628035477

Tests and validation

  • Focused Testbox Chromium suite: 55/55 passed.
  • git diff --check: passed.
  • Fresh autoreview: clean, no actionable findings.

Risk checklist

  • User-visible behavior change: No.
  • Config, environment, or migration behavior change: No.
  • Security, auth, secrets, network, or tool execution behavior change: No.
  • Highest-risk area: accidentally masking a deterministic UI regression.
  • Mitigation: assertions and inner waits are unchanged; only the contradictory outer budget is raised and remains bounded.

Current review state

Next action: hosted CI, then land into release/2026.7.1 if green.

No author action is pending.

@openclaw-barnacle openclaw-barnacle Bot added app: web-ui App: web-ui size: XS maintainer Maintainer-authored PR labels Jul 12, 2026
@steipete

Copy link
Copy Markdown
Contributor Author

Land-ready proof:

  • Exact head: 406e8c36920c3bef2b153080a5f00c74ae2b430b
  • Blacksmith Testbox: tbx_01kxagrw2f2vhbfz5atjnr1k4h
  • Focused Chromium suite: ui/src/pages/chat/chat-responsive.browser.test.ts — 55/55 passed; affected case 1.529s.
  • Fresh autoreview: clean, no actionable findings.
  • Hosted PR checks: green.

The change only aligns the bounded outer test budget with the existing 10-second browser wait; assertions remain unchanged.

@steipete
steipete merged commit 1246965 into release/2026.7.1 Jul 12, 2026
94 of 97 checks passed
@steipete
steipete deleted the codex/beta-chat-hover-timeout branch July 12, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: web-ui App: web-ui maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant