test(qa): wait for durable webchat transcript#103718
Merged
Merged
Conversation
Contributor
Author
|
Land-ready proof for
Known release gap: Codex token overhead still exceeds the unchanged 15% release threshold. This PR removes the false-success zero-usage race; it does not relax that gate or claim the broader token-efficiency blocker is resolved. |
Contributor
Author
|
Merged via squash.
|
steipete
added a commit
that referenced
this pull request
Jul 10, 2026
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Closes #103701.
The live webchat runtime-parity scenario could pass after seeing transport output but before the assistant transcript row was durable. That left an assistant-required usage row at zero even though the scenario reported success.
Why This Change Was Made
The scenario now waits for the expected marker in the persisted session transcript. It retries only known not-yet-durable states and propagates deterministic read failures immediately. Behavior-level flow tests cover a missing file, an empty transcript, eventual persistence, and a non-retryable permission failure.
User Impact
Release QA no longer records false-success zero-usage webchat cells. The existing fail-closed runtime token gate and 15% threshold are unchanged.
Evidence
tbx_01kx63z1ngbqdygp3ewthcqsev: 59 focused tests plus all-lane changed checks, typecheck, lint, guards, and import-cycle checks passed.ba1af773: OpenClaw and Codex both persistedWEBCHAT-DIRECT-REPLY-OK, with nonzero usage (14,683 and 21,663 tokens). Testbox run: https://github.com/openclaw/openclaw/actions/runs/29097879091