Skip to content

refactor(qa-lab): localize evidence summary schemas#101987

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260708-v77
Jul 8, 2026
Merged

refactor(qa-lab): localize evidence summary schemas#101987
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260708-v77

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

QA Lab's evidence summary module exported two Zod schemas and one inferred profile type that have no repository consumers and are not part of the extension's supported API barrel.

Why This Change Was Made

Keep those declarations private to their owning module while preserving the exported derived summary types and all runtime validation behavior.

User Impact

None. This is an internal dead-code/API-surface cleanup with no runtime or schema-shape change.

Evidence

  • Codebase-memory graph refreshed from the full worktree: 281,363 nodes / 1,133,845 edges.
  • Repository-wide symbol search found no external consumers for the three removed exports.
  • pnpm check:changed passed on Blacksmith Testbox tbx_01kwztevdpjcffrcb2frhdecfw.
  • pnpm test:serial extensions/qa-lab/src/evidence-summary.test.ts passed: 1 file, 14 tests.
  • pnpm build passed on the same Testbox.
  • Fresh local autoreview: clean, confidence 0.89.
  • Fresh branch autoreview: clean, confidence 0.86.

@vincentkoc vincentkoc self-assigned this Jul 8, 2026
@vincentkoc

Copy link
Copy Markdown
Member Author

Land-ready proof:

  • Exact PR head: d823d8ecd075ba6e7087ccb6c3c5d17aa5231ac2
  • Base verified against current origin/main: 5bdea31c945505b0b8f0af35f938097d0ca918c8
  • Codebase-memory graph refreshed from the fresh full worktree: 281,363 nodes / 1,133,845 edges
  • Repository-wide symbol search found no external consumers for the removed exports
  • Blacksmith Testbox tbx_01kwztevdpjcffrcb2frhdecfw:
    • pnpm check:changed passed
    • pnpm test:serial extensions/qa-lab/src/evidence-summary.test.ts passed: 1 file, 14 tests
    • pnpm build passed
  • Fresh autoreview:
    • local: clean, confidence 0.89
    • branch: clean, confidence 0.86
  • scripts/pr review-validate-artifacts 101987 passed with recommendation READY FOR /prepare-pr
  • OPENCLAW_TESTBOX=1 scripts/pr prepare-run 101987 passed

Known proof gaps: none for this internal export-visibility refactor.

@vincentkoc
vincentkoc marked this pull request as ready for review July 8, 2026 03:08
@vincentkoc
vincentkoc merged commit a24f15d into main Jul 8, 2026
116 of 118 checks passed
@vincentkoc
vincentkoc deleted the refactor/deadcode-all-surfaces-20260708-v77 branch July 8, 2026 03:09
@vincentkoc

Copy link
Copy Markdown
Member Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant