Skip to content

refactor(whatsapp): localize internal types#101959

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260708-v72
Jul 8, 2026
Merged

refactor(whatsapp): localize internal types#101959
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260708-v72

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

WhatsApp implementation and QA modules exported 14 type aliases that have no consumers outside their defining files and are not named by the plugin's public, runtime, contract, or test API barrels.

Why This Change Was Made

File-private helper types should not expand the apparent package surface. Localizing them improves dead-code and API analysis while preserving higher-level exported declarations and all runtime behavior.

User Impact

No behavior change. WhatsApp runtime behavior and published API barrels remain unchanged.

Evidence

  • Fresh full codebase-memory MCP graph: 281,358 nodes and 1,133,963 edges.
  • MCP search_graph and repository-wide scans found only defining-module references for the localized types.
  • Audited public, runtime, contract, setup, security, doctor, directory, and test barrels; none name these aliases.
  • TypeScript production/test declaration checks passed with non-exported helper aliases referenced by still-public outer types.
  • Testbox tbx_01kwzq1hd83ajch1bnk6zq1yrs: pnpm check:changed passed.
  • pnpm test:serial extensions/whatsapp passed: 86 files, 1,029 tests.
  • pnpm build passed, including plugin SDK export guards and the Control UI build.
  • Local autoreview: clean, confidence 0.90.
  • Branch autoreview after rebasing onto current origin/main: clean, confidence 0.91.
  • Diff: eight files, 14 localized types, net two production lines removed.

@vincentkoc vincentkoc self-assigned this Jul 8, 2026
@openclaw-barnacle openclaw-barnacle Bot added channel: whatsapp-web Channel integration: whatsapp-web size: XS maintainer Maintainer-authored PR labels Jul 8, 2026
@vincentkoc

Copy link
Copy Markdown
Member Author

Land-ready proof:

  • Fresh full codebase-memory MCP graph: 281,358 nodes / 1,133,963 edges; search_graph resolved the audited WhatsApp definitions.
  • Repository-wide scans and all WhatsApp public/runtime/contract/setup/security/doctor/directory/test barrel checks found no consumers or named exposure for the 14 localized types.
  • Production/test declaration checks passed, including public outer types that reference private helper aliases.
  • Testbox tbx_01kwzq1hd83ajch1bnk6zq1yrs: pnpm check:changed passed.
  • pnpm test:serial extensions/whatsapp passed: 86 files, 1,029 tests.
  • pnpm build passed, including plugin SDK export guards and the Control UI build.
  • Fresh autoreview passed before commit at 0.90 and after rebasing onto current origin/main at 0.91.
  • Repo review artifacts validate with recommendation READY FOR /prepare-pr; scripts/pr prepare-run 101959 passed.

Known gaps: none for this type-export-only refactor.

@vincentkoc
vincentkoc marked this pull request as ready for review July 8, 2026 02:05
@vincentkoc
vincentkoc merged commit 94da0a9 into main Jul 8, 2026
106 of 111 checks passed
@vincentkoc
vincentkoc deleted the refactor/deadcode-all-surfaces-20260708-v72 branch July 8, 2026 02:05
@vincentkoc

Copy link
Copy Markdown
Member Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

channel: whatsapp-web Channel integration: whatsapp-web maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant