Skip to content

refactor(imessage): localize internal helper symbols#101936

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260708-v67
Jul 8, 2026
Merged

refactor(imessage): localize internal helper symbols#101936
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260708-v67

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

The private iMessage plugin still exported twenty-five helper types, constants,
and one normalization function that are only referenced inside their defining
modules. Those exports enlarge the apparent implementation API and add noise to
dead-code analysis.

Why This Change Was Made

Localize the remaining declarations while preserving the exports intentionally
exposed by extensions/imessage/api.ts. This is a module-surface cleanup only;
definitions, callers, values, and control flow are unchanged.

User Impact

No user-visible behavior change. The bundled private plugin exposes a smaller,
more accurate internal module surface.

Evidence

  • Fresh full, non-shallow worktree from origin/main at 81d0f3f37291b199005ace7c55db1d9c6d060c70
  • codebase-memory graph refreshed on commit 765c1b36e98d3b21fe0f3abbee1098cc7b52b8d4: 21,043 files, 281,325 nodes, 1,139,718 edges
  • repository-wide source scan confirms all twenty-five declarations are confined to their defining modules
  • post-edit scanner reports zero remaining iMessage candidates in this batch
  • Testbox tbx_01kwzk7wy9zabpb7dsy18mxyvk: pnpm check:changed
  • Testbox tbx_01kwzk7wy9zabpb7dsy18mxyvk: iMessage suite, 60 files / 726 tests passed
  • Testbox tbx_01kwzk7wy9zabpb7dsy18mxyvk: full pnpm build
  • fresh local autoreview: clean, confidence 0.89
  • fresh branch autoreview: clean, confidence 0.86
  • git diff --check

@vincentkoc vincentkoc self-assigned this Jul 8, 2026
@openclaw-barnacle openclaw-barnacle Bot added channel: imessage Channel integration: imessage size: S maintainer Maintainer-authored PR labels Jul 8, 2026
@vincentkoc

Copy link
Copy Markdown
Member Author

Land-ready proof:

  • base: origin/main at 81d0f3f37291b199005ace7c55db1d9c6d060c70
  • head: 765c1b36e98d3b21fe0f3abbee1098cc7b52b8d4
  • graph: refreshed, 21,043 files / 281,325 nodes / 1,139,718 edges
  • Testbox: tbx_01kwzk7wy9zabpb7dsy18mxyvk
  • pnpm check:changed: passed
  • iMessage tests: 60 files / 726 tests passed
  • full pnpm build: passed
  • local autoreview: clean, confidence 0.89
  • branch autoreview: clean, confidence 0.86
  • known proof gaps: none

@vincentkoc
vincentkoc marked this pull request as ready for review July 8, 2026 01:00
@vincentkoc
vincentkoc merged commit ef91bb3 into main Jul 8, 2026
118 of 121 checks passed
@vincentkoc
vincentkoc deleted the refactor/deadcode-all-surfaces-20260708-v67 branch July 8, 2026 01:00
@vincentkoc

Copy link
Copy Markdown
Member Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

channel: imessage Channel integration: imessage maintainer Maintainer-authored PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant