Skip to content

refactor(deadcode): localize AI provider declarations#101907

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260707-v61
Jul 7, 2026
Merged

refactor(deadcode): localize AI provider declarations#101907
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260707-v61

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

Thirteen provider-internal TypeScript declarations were exported from lazy @openclaw/ai implementation modules even though no repository consumer imports them and none are exposed through the package entrypoints.

Why This Change Was Made

Localize those declarations to their owning modules. This narrows the implementation surface without changing runtime code, the public package barrels, or the exported provider stream functions.

User Impact

None. This is export-surface deadcode cleanup with no runtime behavior change.

Evidence

  • Repository-wide export-consumer scan confirmed the 13 declarations have no external consumers.
  • Clean codebase-memory MCP rebuild indexed 21,043 files, 281,315 nodes, and 1,134,113 edges with zero extraction errors.
  • MCP source proof shows GoogleOptions is module-local while streamGoogle and streamSimpleGoogle remain exported.
  • OPENCLAW_TESTBOX=1 pnpm check:changed passed on Testbox tbx_01kwzdwsfjdhgp7hh0w17ykb28.
  • Eight focused provider test files passed: 94 tests in one Vitest shard.
  • Full pnpm build passed on the same Testbox.
  • Local autoreview passed with no findings at 0.86 confidence.
  • Branch autoreview passed with no findings at 0.92 confidence.
  • Testbox run: https://github.com/openclaw/openclaw/actions/runs/28905346491

@openclaw-barnacle openclaw-barnacle Bot added size: XS maintainer Maintainer-authored PR labels Jul 7, 2026
@vincentkoc vincentkoc self-assigned this Jul 7, 2026
@clawsweeper

clawsweeper Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper status: review started.

I am starting a fresh review of this pull request: refactor(deadcode): localize AI provider declarations This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@vincentkoc

Copy link
Copy Markdown
Member Author

Land-ready proof:

  • Commit: 799614badf4ed055214c12dc731fce534572281a
  • OPENCLAW_TESTBOX=1 pnpm check:changed: passed
  • Focused provider tests: 8 files, 94 tests, 1 Vitest shard: passed
  • corepack pnpm build: passed
  • Testbox: tbx_01kwzdwsfjdhgp7hh0w17ykb28
  • Hosted run: https://github.com/openclaw/openclaw/actions/runs/28905346491
  • Clean codebase-memory MCP rebuild: 21,043 files, 281,315 nodes, 1,134,113 edges, zero extraction errors
  • Local autoreview: no findings, 0.86 confidence
  • Branch autoreview: no findings, 0.92 confidence
  • scripts/pr review-guard 101907: passed
  • scripts/pr review-validate-artifacts 101907: passed with READY FOR /prepare-pr
  • OPENCLAW_TESTBOX=1 scripts/pr prepare-run 101907: passed

No proof gaps. The diff only localizes 13 unconsumed provider implementation declarations; runtime exports and public package entrypoints are unchanged.

@vincentkoc
vincentkoc marked this pull request as ready for review July 7, 2026 23:26
@vincentkoc
vincentkoc merged commit 380bc24 into main Jul 7, 2026
75 of 78 checks passed
@vincentkoc
vincentkoc deleted the refactor/deadcode-all-surfaces-20260707-v61 branch July 7, 2026 23:26
@vincentkoc

Copy link
Copy Markdown
Member Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant