Skip to content

refactor(plugins): localize private config types#101452

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-native-sweep-20260707-v32
Jul 7, 2026
Merged

refactor(plugins): localize private config types#101452
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-native-sweep-20260707-v32

Conversation

@vincentkoc

@vincentkoc vincentkoc commented Jul 7, 2026

Copy link
Copy Markdown
Member

What Problem This Solves

Three plugin-internal configuration and catalog types remained exported even though no repository consumer or public plugin barrel used them. That inflated the apparent module API and kept known private symbols in the unused-export report.

Why This Change Was Made

Make the OpenRouter catalog capability type and two SMS configuration helper types module-local. Runtime behavior, public plugin entrypoints, and the remaining exported structural contracts are unchanged.

User Impact

No runtime or user-visible behavior changes. Maintainers get a smaller private plugin surface and three fewer false-positive unused exports.

Evidence

  • AI-assisted: yes.
  • Fresh full worktree from current origin/main; codebase-memory graph refreshed after each main rebase.
  • Current graph: 278,152 nodes / 1,122,416 edges.
  • Repository search and graph incoming edges show only same-file definitions/usages for the three types.
  • Testbox tbx_01kwxq03svr2bytrzg9cc2zv37:
    • pnpm test:serial extensions/openrouter/video-generation-provider.test.ts extensions/sms/src/accounts.test.ts — 2 files / 29 tests passed.
    • pnpm check:changed — passed extension typechecks, lint, guards, and import-cycle checks.
    • pnpm deadcode:report:ci:ts-unused — all three targeted entries changed from present to absent.
  • Fresh autoreview after the final rebase: no findings; patch correct, confidence 0.88.

@vincentkoc vincentkoc self-assigned this Jul 7, 2026
@openclaw-barnacle openclaw-barnacle Bot added extensions: openrouter channel: sms Channel integration: sms size: XS maintainer Maintainer-authored PR labels Jul 7, 2026
@vincentkoc
vincentkoc force-pushed the refactor/deadcode-native-sweep-20260707-v32 branch from 00e775f to ae1bd4a Compare July 7, 2026 07:30
@vincentkoc

Copy link
Copy Markdown
Member Author

Land-ready proof for ae1bd4a3733188454b96725701d931c29a857a3b:

  • Independent repo-native review artifacts validated with READY FOR /prepare-pr, zero findings, valid issue intent, and a passing behavioral sweep.
  • Testbox tbx_01kwxq03svr2bytrzg9cc2zv37:
    • pnpm test:serial extensions/openrouter/video-generation-provider.test.ts extensions/sms/src/accounts.test.ts passed 2 files / 29 tests.
    • pnpm check:changed passed extension typechecks, extension-test typechecks, lint, repository guards, and runtime import-cycle checks.
    • pnpm deadcode:report:ci:ts-unused reported zero remaining matches for OpenRouterVideoModelCatalogCapabilities, SmsChannelConfigFields, and SmsAccountRaw.
  • git diff --check passed.
  • Fresh post-rebase autoreview: no findings, patch correct, confidence 0.88.
  • Codebase-memory graph refreshed on the exact head: 278,152 nodes / 1,122,416 edges.
  • OPENCLAW_TESTBOX=1 scripts/pr prepare-run 101452 passed in hosted_exact_or_recent_rebase mode and verified the remote PR head tree matches the prepared head.
  • GitHub checks: 65 successful / skipped as intended, zero attention items.

The direct local Vitest attempt was blocked by the linked checkout's missing markdown-it-cjk-friendly dependency; the same targeted tests passed in the warmed Testbox.

@vincentkoc
vincentkoc marked this pull request as ready for review July 7, 2026 07:34
@vincentkoc
vincentkoc merged commit 1aeed5e into main Jul 7, 2026
93 checks passed
@vincentkoc
vincentkoc deleted the refactor/deadcode-native-sweep-20260707-v32 branch July 7, 2026 07:34
@vincentkoc

Copy link
Copy Markdown
Member Author

Merged via squash.

github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 7, 2026
sheyanmin pushed a commit to sheyanmin/openclaw that referenced this pull request Jul 8, 2026
giodl73-repo pushed a commit to giodl73-repo/openclaw that referenced this pull request Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

channel: sms Channel integration: sms extensions: openrouter maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant