Skip to content

fix(minimax): clarify TTS volume boundary#101359

Merged
steipete merged 1 commit into
mainfrom
codex/fix-minimax-volume-boundary
Jul 7, 2026
Merged

fix(minimax): clarify TTS volume boundary#101359
steipete merged 1 commit into
mainfrom
codex/fix-minimax-volume-boundary

Conversation

@steipete

@steipete steipete commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Related: #93397

What Problem This Solves

Fixes an issue where users who supplied an invalid MiniMax TTS volume directive saw a warning that described both range endpoints as exclusive, even though MiniMax and OpenClaw accept 10 and reject only values at or below 0 or above 10.

Why This Change Was Made

The warning now states the boundary in plain language: volume must be greater than 0 and at most 10. Exact boundary tests cover rejected values 0 and 11, preserve acceptance of 10, and the public TTS directive reference now uses the canonical (0, 10] notation.

This is a maintainer replacement for #93397 because the contributor branch was based far behind current main; refreshing that fork through GitHub's verified-commit API would have required replaying thousands of unrelated files. The useful contributor change is preserved with co-author credit.

User Impact

MiniMax TTS users now receive an accurate, unambiguous volume warning and see the same boundary in the TTS documentation. Numeric parsing and synthesis behavior are unchanged.

Evidence

  • Current MiniMax T2A HTTP documentation declares voice_setting.vol as (0, 10] with exclusiveMinimum: 0 and maximum: 10.
  • Focused regression coverage asserts the exact warning for vol=0 and vol=11, while vol=10 remains accepted without a warning.
  • Fresh Codex autoreview on the current-main diff reported no accepted/actionable findings.
  • Blacksmith Testbox through Crabbox tbx_01kwxe0113trnv147sx2kb4j27 (Actions run 28841981897): pnpm test extensions/minimax/speech-provider.test.ts passed 39 tests; pnpm check:changed passed.
  • Repo-native prepare verified exact head 6d02a4ab2db5414c70d65eb0966ad822b0d5ed68 against hosted CI/Testbox gates.

Co-authored-by: Quratulain-bilal <umayaimanshah@gmail.com>
@openclaw-barnacle openclaw-barnacle Bot added docs Improvements or additions to documentation extensions: minimax extensions: tts-local-cli plugin: azure-speech Azure Speech plugin size: XS maintainer Maintainer-authored PR labels Jul 7, 2026
@steipete steipete self-assigned this Jul 7, 2026
@steipete

steipete commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Land-ready maintainer proof for exact head 6d02a4ab2db5414c70d65eb0966ad822b0d5ed68:

  • Official MiniMax T2A contract: voice_setting.vol is (0, 10] (exclusiveMinimum: 0, maximum: 10).
  • Blacksmith Testbox through Crabbox tbx_01kwxe0113trnv147sx2kb4j27, Actions run https://github.com/openclaw/openclaw/actions/runs/28841981897: focused MiniMax provider test passed (39 tests).
  • Same Testbox: pnpm check:changed passed for extension source/tests and docs.
  • node scripts/docs-list.js passed.
  • Fresh Codex autoreview on the exact current-main diff: no accepted/actionable findings.
  • Repo-native OPENCLAW_TESTBOX=1 scripts/pr prepare-run 101359 verified exact-head hosted gates.

Known proof gap: no authenticated synthesis call was run because request parsing, normalized overrides, and provider API request behavior are unchanged; this corrects only warning/docs text.

@steipete
steipete merged commit 90b6804 into main Jul 7, 2026
142 of 146 checks passed
@steipete

steipete commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Merged via squash.

@steipete
steipete deleted the codex/fix-minimax-volume-boundary branch July 7, 2026 04:53
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 7, 2026
Co-authored-by: Quratulain-bilal <umayaimanshah@gmail.com>
sheyanmin pushed a commit to sheyanmin/openclaw that referenced this pull request Jul 8, 2026
Co-authored-by: Quratulain-bilal <umayaimanshah@gmail.com>
giodl73-repo pushed a commit to giodl73-repo/openclaw that referenced this pull request Jul 8, 2026
Co-authored-by: Quratulain-bilal <umayaimanshah@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation extensions: minimax extensions: tts-local-cli maintainer Maintainer-authored PR plugin: azure-speech Azure Speech plugin size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant