fix(minimax): clarify TTS volume boundary#101359
Merged
Merged
Conversation
Co-authored-by: Quratulain-bilal <umayaimanshah@gmail.com>
Contributor
Author
|
Land-ready maintainer proof for exact head
Known proof gap: no authenticated synthesis call was run because request parsing, normalized overrides, and provider API request behavior are unchanged; this corrects only warning/docs text. |
Contributor
Author
|
Merged via squash.
|
3 tasks
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 7, 2026
Co-authored-by: Quratulain-bilal <umayaimanshah@gmail.com>
sheyanmin
pushed a commit
to sheyanmin/openclaw
that referenced
this pull request
Jul 8, 2026
Co-authored-by: Quratulain-bilal <umayaimanshah@gmail.com>
giodl73-repo
pushed a commit
to giodl73-repo/openclaw
that referenced
this pull request
Jul 8, 2026
Co-authored-by: Quratulain-bilal <umayaimanshah@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #93397
What Problem This Solves
Fixes an issue where users who supplied an invalid MiniMax TTS volume directive saw a warning that described both range endpoints as exclusive, even though MiniMax and OpenClaw accept
10and reject only values at or below0or above10.Why This Change Was Made
The warning now states the boundary in plain language: volume must be greater than 0 and at most 10. Exact boundary tests cover rejected values
0and11, preserve acceptance of10, and the public TTS directive reference now uses the canonical(0, 10]notation.This is a maintainer replacement for #93397 because the contributor branch was based far behind current
main; refreshing that fork through GitHub's verified-commit API would have required replaying thousands of unrelated files. The useful contributor change is preserved with co-author credit.User Impact
MiniMax TTS users now receive an accurate, unambiguous volume warning and see the same boundary in the TTS documentation. Numeric parsing and synthesis behavior are unchanged.
Evidence
voice_setting.volas(0, 10]withexclusiveMinimum: 0andmaximum: 10.vol=0andvol=11, whilevol=10remains accepted without a warning.tbx_01kwxe0113trnv147sx2kb4j27(Actions run 28841981897):pnpm test extensions/minimax/speech-provider.test.tspassed 39 tests;pnpm check:changedpassed.6d02a4ab2db5414c70d65eb0966ad822b0d5ed68against hosted CI/Testbox gates.