Skip to content

fix(android): restore lint validation#101081

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-full-sweep-20260706-v16
Jul 6, 2026
Merged

fix(android): restore lint validation#101081
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-full-sweep-20260706-v16

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

Android validation on current main was blocked by two ktlint findings in the overview helpers and one Compose ModifierParameter lint error in the Voice controls.

Why This Change Was Made

  • Keep the short overview expression-body helpers in ktlint's canonical single-line form.
  • Place the optional modifier parameter before the other optional TalkControl parameter, as required by the Compose API guideline.
  • Preserve runtime behavior; all TalkControl call sites use named arguments.

User Impact

No product behavior changes. Android ktlint and framework lint can run cleanly again.

Evidence

  • :app:ktlintCheck :benchmark:ktlintCheck passed on Blacksmith Testbox tbx_01kww8cwq56t8ycpqkapc0ma2v.
  • :app:lintPlayDebug :app:lintThirdPartyDebug passed on the same Testbox.
  • pnpm check:changed passed on Blacksmith Testbox tbx_01kww8shz65dh918n34yzgz1gp.
  • Codex autoreview on the rebased branch reported no accepted/actionable findings, confidence 0.96.

@vincentkoc
vincentkoc marked this pull request as ready for review July 6, 2026 17:51
@vincentkoc vincentkoc self-assigned this Jul 6, 2026
@openclaw-barnacle openclaw-barnacle Bot added app: android App: android size: XS maintainer Maintainer-authored PR labels Jul 6, 2026
@vincentkoc
vincentkoc force-pushed the refactor/deadcode-full-sweep-20260706-v16 branch from e58c114 to f8803c6 Compare July 6, 2026 18:38
@vincentkoc
vincentkoc force-pushed the refactor/deadcode-full-sweep-20260706-v16 branch from f8803c6 to fc101e9 Compare July 6, 2026 18:43
@clawsweeper

clawsweeper Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper status: review started.

I am starting a fresh review of this pull request: fix(android): restore lint validation This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@vincentkoc
vincentkoc merged commit 70add7d into main Jul 6, 2026
83 of 85 checks passed
@vincentkoc
vincentkoc deleted the refactor/deadcode-full-sweep-20260706-v16 branch July 6, 2026 18:57
@vincentkoc

Copy link
Copy Markdown
Member Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: android App: android maintainer Maintainer-authored PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant