fix(android): restore lint validation#101081
Merged
Merged
Conversation
vincentkoc
marked this pull request as ready for review
July 6, 2026 17:51
vincentkoc
force-pushed
the
refactor/deadcode-full-sweep-20260706-v16
branch
from
July 6, 2026 18:38
e58c114 to
f8803c6
Compare
vincentkoc
force-pushed
the
refactor/deadcode-full-sweep-20260706-v16
branch
from
July 6, 2026 18:43
f8803c6 to
fc101e9
Compare
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(android): restore lint validation This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
Member
Author
|
Merged via squash.
|
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 7, 2026
giodl73-repo
pushed a commit
to giodl73-repo/openclaw
that referenced
this pull request
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Android validation on current
mainwas blocked by two ktlint findings in the overview helpers and one ComposeModifierParameterlint error in the Voice controls.Why This Change Was Made
modifierparameter before the other optionalTalkControlparameter, as required by the Compose API guideline.TalkControlcall sites use named arguments.User Impact
No product behavior changes. Android ktlint and framework lint can run cleanly again.
Evidence
:app:ktlintCheck :benchmark:ktlintCheckpassed on Blacksmith Testboxtbx_01kww8cwq56t8ycpqkapc0ma2v.:app:lintPlayDebug :app:lintThirdPartyDebugpassed on the same Testbox.pnpm check:changedpassed on Blacksmith Testboxtbx_01kww8shz65dh918n34yzgz1gp.