fix(android): finish onboarding after permission reapproval#100959
Merged
Conversation
steipete
force-pushed
the
codex/android-onboarding-approval-flow
branch
from
July 6, 2026 15:00
7cac852 to
f1353db
Compare
Contributor
Author
|
Land-ready proof for head
Known gap: no physical-device QR/approval automation. The transition contract is covered directly and both Android CI flavors are green. |
Contributor
Author
|
Merged via squash.
|
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 7, 2026
…#100959) * fix(android): finish onboarding after permission reapproval * chore(android): sync onboarding i18n inventory
giodl73-repo
pushed a commit
to giodl73-repo/openclaw
that referenced
this pull request
Jul 8, 2026
…#100959) * fix(android): finish onboarding after permission reapproval * chore(android): sync onboarding i18n inventory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #100949
What Problem This Solves
Fixes an issue where Android users who enabled node capabilities during onboarding could be sent back to Permissions after approving the resulting node capability request. The independently mutable Permissions and approval back targets could then point at each other, trapping users in a navigation cycle instead of completing onboarding.
Why This Change Was Made
The post-pairing flow now uses one closed access stage for direct permissions, initial approval, and permission reapproval. Each stage owns its Back destinations and approval-success action: initial approval still advances to Permissions, while permission reapproval completes onboarding because those permission choices were already applied.
User Impact
Android QR/setup-code onboarding now finishes immediately after successful permission-triggered node approval. Before approval completes, users can still go back to review Permissions, then back again to gateway recovery without cycling.
Evidence
tbx_01kwvxxt0fp3qq399nw143hsb9:cd apps/android && ./gradlew :app:testPlayDebugUnitTest --tests ai.openclaw.app.ui.OnboardingFlowLogicTest --no-daemon— passed; Play debug Kotlin compilation included.CompleteOnboarding..agents/skills/autoreview/scripts/autoreview --mode local --stream-engine-output— clean, no accepted/actionable findings; patch correct at 0.95 confidence.git diff --check— passed.:app:ktlintCheckreached and passed the touched main source, then stopped on pre-existing violations inCronJobDetailTest.kt,InvokeErrorParserTest.kt, andNodeUtilsTest.kt; none are changed here.AI-assisted: yes. The implementation and regression contract were reviewed before commit.