Skip to content

fix(protocol): remove duplicate worktree type exports#100825

Closed
steipete wants to merge 1 commit into
mainfrom
codex/fix-duplicate-worktree-exports
Closed

fix(protocol): remove duplicate worktree type exports#100825
steipete wants to merge 1 commit into
mainfrom
codex/fix-duplicate-worktree-exports

Conversation

@steipete

@steipete steipete commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

What Problem This Solves

The two overlapping managed-worktree protocol follow-ups, #100793 and #100804, both exported SessionWorktreeInfo and SessionsCreateResult from packages/gateway-protocol/src/index.ts. Their combined mainline state fails production types, lint, and plugin SDK declaration checks with duplicate identifiers.

Why This Change Was Made

Keep the canonical type-only exports in the existing export type block added by #100804 and remove the duplicate type entries from the schema/value export block added by #100793. Runtime schemas and the public TypeScript names remain exported.

User Impact

No runtime, config, or protocol behavior changes. Mainline CI and dependent PR validation can compile the gateway protocol barrel again.

Evidence

  • Blacksmith Testbox tidal-shrimp / tbx_01kwvc817e5sdgdcf6c46r79q5
  • oxfmt --check packages/gateway-protocol/src/index.ts
  • oxlint --threads=1 packages/gateway-protocol/src/index.ts
  • core tsgo via scripts/run-tsgo.mjs
  • gateway protocol worktree/schema tests: 13 passed
  • git diff --check

No agent transcript attached; this is a two-line generated-barrel repair with the exact remote proof above.

@openclaw-barnacle openclaw-barnacle Bot added app: web-ui App: web-ui gateway Gateway runtime size: XS maintainer Maintainer-authored PR labels Jul 6, 2026
@steipete

steipete commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Land-ready proof for 63a35f41a51ef4a18e83aef6c862f9f29d8a0566:

  • Blacksmith Testbox tidal-shrimp / tbx_01kwvc817e5sdgdcf6c46r79q5
  • oxfmt --check packages/gateway-protocol/src/index.ts
  • oxlint --threads=1 packages/gateway-protocol/src/index.ts
  • core tsgo via scripts/run-tsgo.mjs
  • gateway protocol managed-worktree/schema tests: 13 passed
  • git diff --check
  • fresh autoreview: clean, no actionable findings
  • exact-head hosted CI: https://github.com/openclaw/openclaw/actions/runs/28785112157 (all required jobs passed)
  • native land guard: OPENCLAW_TESTBOX=1 scripts/pr prepare-run 100825 passed with exact local/remote head match

Before: the barrel exported SessionWorktreeInfo and SessionsCreateResult twice, breaking TypeScript and lint checks. After: each type has one canonical type-only export; runtime schemas and public type names remain available. No remaining proof gaps.

@steipete

steipete commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by the exact repair now on main: 8ce620f3e675.

That commit removes the same two duplicate type exports while preserving the canonical export type entries and runtime schemas. The focused Testbox proof and exact-head hosted gates for this patch were green; no additional behavior remains here. Closing the duplicate PR.

@steipete steipete closed this Jul 6, 2026
@steipete

steipete commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Maintainer verification complete at exact head 63a35f41a51ef4a18e83aef6c862f9f29d8a0566.

  • Best-fix review: remove only the duplicate type entries from the mixed schema/value barrel; retain the canonical explicit export type entries and both runtime schemas.
  • Blacksmith Testbox tbx_01kwvc817e5sdgdcf6c46r79q5: oxfmt, oxlint, core tsgo, 13 gateway protocol tests, and diff check passed.
  • Hosted CI run 28785112157 passed at the exact head: QA Smoke, build, prod/test types, lint, protocol contracts, Node shards, and CodeQL.
  • Fresh branch autoreview: clean (0.86). No docs, changelog, runtime, config, or wire-protocol change required.

Native review artifacts validate with no findings; ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: web-ui App: web-ui gateway Gateway runtime maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant