docs(changelog): record five landed fixes#100441
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb058b16cd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| - **MCP loopback tool results:** preserve schema-valid text, image, and embedded-resource content through HTTP tool calls while rendering malformed or protocol-incompatible blocks as safe text. (#100336) Thanks @tzy-17. | ||
| - **Control UI tool-result images:** render direct image content blocks from Gateway history and make the delayed-send scroll E2E setup deterministic. (#100295) Thanks @lzyyzznl. | ||
| - **Plugin approval diagnostics:** surface Gateway validation rejection reasons while keeping transport and availability failures fail-closed. (#100337) Thanks @tzy-17. |
There was a problem hiding this comment.
This Unreleased entry says Gateway validation rejection reasons are now surfaced, but the current runtime still catches any plugin.approval.request/wait failure in requestPluginToolApproval and replaces it with the generic Plugin approval required (gateway unavailable) (src/agents/agent-tools.before-tool-call.ts:930-935). The Gateway validator does emit the detailed invalid plugin.approval.request params: ... request error (src/gateway/server-methods/plugin-approval.ts:40-48), but malformed approval requests still won't show it to users, so the changelog is advertising a fix that has not landed yet.
Useful? React with 👍 / 👎.
|
Codex review: stale review; fresh review needed. Summary Next step |
cb058b1 to
25dfcdc
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 25dfcdc5a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| - **iOS QR gateway handoff:** stop VisionKit before delivering scanned setup codes, and keep deferred auth, approval, Watch, and foreground-node work bound to its originating gateway across reconnects. (#99572) Thanks @PollyBot13. | ||
| - **MCP loopback tool results:** preserve schema-valid text, image, and embedded-resource content through HTTP tool calls while rendering malformed or protocol-incompatible blocks as safe text. (#100336) Thanks @tzy-17. | ||
| - **Control UI tool-result images:** render direct image content blocks from Gateway history and make the delayed-send scroll E2E setup deterministic. (#100295) Thanks @lzyyzznl. |
There was a problem hiding this comment.
This entry advertises #100295 as a landed release-note fix, but that PR is still open and the current renderer still drops the direct tool-result shape it is meant to fix: extractImages() handles type: "image" only when there is a source.base64 object or url, and has no branch for { type: "image", data, mimeType } (ui/src/pages/chat/components/chat-message.ts:345-364). If this changelog ships now, users will expect read/tool-result images from Gateway history to render inline even though that behavior has not landed.
Useful? React with 👍 / 👎.
25dfcdc to
99d5616
Compare
|
Merged via squash.
|
What Problem This Solves
The Unreleased changelog already credited the cron duration fix from this maintainer batch, but four other user-visible fixes had landed without release-note coverage.
Why This Change Was Made
Add one concise entry for each missing fix and preserve contributor credit for the original PR authors.
User Impact
The next release notes now cover MCP loopback content preservation, direct Control UI tool-result images, plugin approval rejection diagnostics, and IRC Unicode-safe chunking.
Evidence
git diff --check