docs: align source contract wording#100186
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 5, 2026, 1:39 AM ET / 05:39 UTC. Summary PR surface: Docs 0. Total 0 across 3 files. Reproducibility: yes. Source inspection shows current main docs do not contain three exact strings asserted by the current docs contract tests; I did not run tests because this review is read-only. Review metrics: none identified. Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Next step before merge
Security Review detailsBest possible solution: Land the narrow docs-only reconciliation through normal maintainer handling once the existing checks remain green. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection shows current main docs do not contain three exact strings asserted by the current docs contract tests; I did not run tests because this review is read-only. Is this the best way to solve the issue? Yes. Updating the three docs lines is the narrowest maintainable fix because the runtime/source-backed tests already define the canonical wording and no runtime behavior needs to change. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 53bdac249dbd. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Docs 0. Total 0 across 3 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Merged via squash.
|
What Problem This Solves
#100182 and #100183 landed concurrently with different exact wording for three documentation guards. The combined
mainstate fails the environment, Talk-default, and cron-fallback contract suites.Why This Change Was Made
Use the canonical wording selected by #100183 while preserving the behavior and broader documentation restored by #100182. This is a three-line docs-only reconciliation; no test expectations are changed.
User Impact
No runtime change. The docs remain accurate, and
mainreturns to a self-consistent source/contract state.Evidence
node scripts/run-vitest.mjs run src/docs/environment-docs.test.ts src/config/talk-defaults.test.ts src/cron/isolated-agent/run-fallback-policy.test.ts— 3 shards passed, 21 tests passedpnpm docs:check-mdx— 690 files passedgit diff --check— passedThe exact failures are visible in pairing follow-up run 28730686889, and each points to one of these three wording mismatches.