Skip to content

Commit b5f754b

Browse files
joshavantjoshavant
committed
Restore gateway secure field accessibility
1 parent 7a1f3d7 commit b5f754b

3 files changed

Lines changed: 30 additions & 22 deletions

File tree

‎apps/.i18n/native-source.json‎

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -9587,175 +9587,175 @@
95879587
},
95889588
{
95899589
"kind": "ui-call",
9590-
"line": 1075,
9590+
"line": 1077,
95919591
"path": "apps/ios/Sources/Design/SettingsProTabSections.swift",
95929592
"source": "Voice Wake",
95939593
"surface": "apple",
95949594
"id": "native.apple.5869824f66e222ed"
95959595
},
95969596
{
95979597
"kind": "ui-call",
9598-
"line": 1078,
9598+
"line": 1080,
95999599
"path": "apps/ios/Sources/Design/SettingsProTabSections.swift",
96009600
"source": "Talk Mode",
96019601
"surface": "apple",
96029602
"id": "native.apple.88a997009842ffa0"
96039603
},
96049604
{
96059605
"kind": "ui-call",
9606-
"line": 1086,
9606+
"line": 1088,
96079607
"path": "apps/ios/Sources/Design/SettingsProTabSections.swift",
96089608
"source": "Speech Language",
96099609
"surface": "apple",
96109610
"id": "native.apple.1f3ab82ab342555c"
96119611
},
96129612
{
96139613
"kind": "ui-call",
9614-
"line": 1094,
9614+
"line": 1096,
96159615
"path": "apps/ios/Sources/Design/SettingsProTabSections.swift",
96169616
"source": "Speakerphone",
96179617
"surface": "apple",
96189618
"id": "native.apple.518cef9408771a92"
96199619
},
96209620
{
96219621
"kind": "ui-named-argument",
9622-
"line": 1099,
9622+
"line": 1101,
96239623
"path": "apps/ios/Sources/Design/SettingsProTabSections.swift",
96249624
"source": "Wake Words",
96259625
"surface": "apple",
96269626
"id": "native.apple.e1383011b9ccc3a3"
96279627
},
96289628
{
96299629
"kind": "ui-call",
9630-
"line": 1121,
9630+
"line": 1123,
96319631
"path": "apps/ios/Sources/Design/SettingsProTabSections.swift",
96329632
"source": "Provider",
96339633
"surface": "apple",
96349634
"id": "native.apple.24ee619948d75837"
96359635
},
96369636
{
96379637
"kind": "ui-call",
9638-
"line": 1129,
9638+
"line": 1131,
96399639
"path": "apps/ios/Sources/Design/SettingsProTabSections.swift",
96409640
"source": "Realtime Voice",
96419641
"surface": "apple",
96429642
"id": "native.apple.47dd7fb00a4eb621"
96439643
},
96449644
{
96459645
"kind": "ui-call",
9646-
"line": 1130,
9646+
"line": 1132,
96479647
"path": "apps/ios/Sources/Design/SettingsProTabSections.swift",
96489648
"source": "Gateway Default",
96499649
"surface": "apple",
96509650
"id": "native.apple.8c4c000f6606efc6"
96519651
},
96529652
{
96539653
"kind": "ui-call",
9654-
"line": 1140,
9654+
"line": 1142,
96559655
"path": "apps/ios/Sources/Design/SettingsProTabSections.swift",
96569656
"source": "Voice Mode",
96579657
"surface": "apple",
96589658
"id": "native.apple.55ddaeb92a2e98ff"
96599659
},
96609660
{
96619661
"kind": "ui-call",
9662-
"line": 1142,
9662+
"line": 1144,
96639663
"path": "apps/ios/Sources/Design/SettingsProTabSections.swift",
96649664
"source": "Active Voice",
96659665
"surface": "apple",
96669666
"id": "native.apple.f384dc02b45f2fde"
96679667
},
96689668
{
96699669
"kind": "ui-call",
9670-
"line": 1145,
9670+
"line": 1147,
96719671
"path": "apps/ios/Sources/Design/SettingsProTabSections.swift",
96729672
"source": "Last Voice Issue",
96739673
"surface": "apple",
96749674
"id": "native.apple.8a8d2629c30d57dd"
96759675
},
96769676
{
96779677
"kind": "ui-call",
9678-
"line": 1148,
9678+
"line": 1150,
96799679
"path": "apps/ios/Sources/Design/SettingsProTabSections.swift",
96809680
"source": "Transport",
96819681
"surface": "apple",
96829682
"id": "native.apple.38c50d290be5736c"
96839683
},
96849684
{
96859685
"kind": "ui-call",
9686-
"line": 1150,
9686+
"line": 1152,
96879687
"path": "apps/ios/Sources/Design/SettingsProTabSections.swift",
96889688
"source": "API Key",
96899689
"surface": "apple",
96909690
"id": "native.apple.6e5b8e1e2b341677"
96919691
},
96929692
{
96939693
"kind": "ui-call",
9694-
"line": 1161,
9694+
"line": 1163,
96959695
"path": "apps/ios/Sources/Design/SettingsProTabSections.swift",
96969696
"source": "Show Talk Control",
96979697
"surface": "apple",
96989698
"id": "native.apple.27457003271bd73d"
96999699
},
97009700
{
97019701
"kind": "ui-call",
9702-
"line": 1164,
9702+
"line": 1166,
97039703
"path": "apps/ios/Sources/Design/SettingsProTabSections.swift",
97049704
"source": "Default Share Instruction",
97059705
"surface": "apple",
97069706
"id": "native.apple.1300f0857e49b6e9"
97079707
},
97089708
{
97099709
"kind": "ui-call",
9710-
"line": 1172,
9710+
"line": 1174,
97119711
"path": "apps/ios/Sources/Design/SettingsProTabSections.swift",
97129712
"source": "Run Share Self-Test",
97139713
"surface": "apple",
97149714
"id": "native.apple.ccb60c6b4d40b204"
97159715
},
97169716
{
97179717
"kind": "ui-call",
9718-
"line": 1194,
9718+
"line": 1196,
97199719
"path": "apps/ios/Sources/Design/SettingsProTabSections.swift",
97209720
"source": "Discovery Debug Logs",
97219721
"surface": "apple",
97229722
"id": "native.apple.dfbbe0f7c038894a"
97239723
},
97249724
{
97259725
"kind": "ui-call",
9726-
"line": 1197,
9726+
"line": 1199,
97279727
"path": "apps/ios/Sources/Design/SettingsProTabSections.swift",
97289728
"source": "Debug Screen Status",
97299729
"surface": "apple",
97309730
"id": "native.apple.c695f785d4f3331a"
97319731
},
97329732
{
97339733
"kind": "ui-named-argument",
9734-
"line": 1201,
9734+
"line": 1203,
97359735
"path": "apps/ios/Sources/Design/SettingsProTabSections.swift",
97369736
"source": "Discovery Logs",
97379737
"surface": "apple",
97389738
"id": "native.apple.2bb13c2d7465f99e"
97399739
},
97409740
{
97419741
"kind": "ui-call",
9742-
"line": 1211,
9742+
"line": 1213,
97439743
"path": "apps/ios/Sources/Design/SettingsProTabSections.swift",
97449744
"source": "Device Name",
97459745
"surface": "apple",
97469746
"id": "native.apple.540b648f9486bb50"
97479747
},
97489748
{
97499749
"kind": "ui-call",
9750-
"line": 1214,
9750+
"line": 1216,
97519751
"path": "apps/ios/Sources/Design/SettingsProTabSections.swift",
97529752
"source": "Instance ID",
97539753
"surface": "apple",
97549754
"id": "native.apple.b7c2d54bc3894446"
97559755
},
97569756
{
97579757
"kind": "conditional-branch",
9758-
"line": 1254,
9758+
"line": 1256,
97599759
"path": "apps/ios/Sources/Design/SettingsProTabSections.swift",
97609760
"source": "On",
97619761
"surface": "apple",

‎apps/ios/Sources/Design/SettingsProTabSections.swift‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1058,12 +1058,14 @@ extension SettingsProTab {
10581058
SecureField("", text: text)
10591059
.font(OpenClawType.subhead)
10601060
.textFieldStyle(.roundedBorder)
1061+
.accessibilityLabel(placeholder)
10611062
if text.wrappedValue.isEmpty {
10621063
Text(placeholder)
10631064
.font(OpenClawType.subheadSemiBold)
10641065
.foregroundStyle(.tertiary)
10651066
.padding(.horizontal, 8)
10661067
.allowsHitTesting(false)
1068+
.accessibilityHidden(true)
10671069
}
10681070
}
10691071
.font(OpenClawType.subhead)

‎apps/ios/Tests/OpenClawTypographyTests.swift‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,12 @@ struct OpenClawTypographyTests {
168168
#expect(settingsSections.contains("func gatewaySecureField"))
169169
#expect(settingsSections.contains("self.gatewaySecureField(\"Gateway Auth Token\""))
170170
#expect(settingsSections.contains("self.gatewaySecureField(\"Gateway Password\""))
171+
let gatewaySecureField = try Self.extract(
172+
settingsSections,
173+
from: "func gatewaySecureField",
174+
to: " var voiceFeatureCard")
175+
#expect(gatewaySecureField.contains(".accessibilityLabel(placeholder)"))
176+
#expect(gatewaySecureField.contains(".accessibilityHidden(true)"))
171177
#expect(settingsSections.contains("Picker(selection: self.$selectedAgentPickerId)"))
172178
#expect(settingsSections.contains("Text(\"Agent\")"))
173179

0 commit comments

Comments
 (0)