fix(ui): vignette no longer washes out content at page bottom#18
Merged
Conversation
The dark-mode edge vignette was a fixed full-viewport overlay (body::before, z-index 0) painting over content. On tall pages (config editor) the bottom content sat in the darkest part of the vignette and became unreadable. Move the vignette into the body background layer (background-image + background-attachment: fixed) so it always renders behind content, and soften it slightly. Fixes the unreadable SCRIPT section at the bottom of /dashboard/edit in dark mode. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a dark-mode readability bug reported on
/dashboard/edit/<slug>: the bottom SCRIPT section was nearly invisible.Root cause: the edge vignette was a fixed full-viewport overlay (
body::before, z-index 0) painting over content. On tall pages the bottom content sat in the darkest part of the vignette and got washed out.Fix: move the vignette into the body background layer (
background-image+background-attachment: fixed) so it always renders behind content, and soften it slightly. This applies globally, so every long page benefits.Test plan
npm run validate— lint/check/test pass, build ✓/dashboard/editbottom SCRIPT section is readable in dark mode