Skip to content

lib: avoid unsafe array iteration in cli table #65838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Sep 9, 2026
Merged

lib: avoid unsafe array iteration in cli table #65838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
lib: avoid unsafe array iteration in cli table 
Avoid unsafe array iteration because for...of relies on the
user-mutable Symbol.iterator. Use an index-based loop instead.

Signed-off-by: HoonDongKang <d159123@naver.com>
  • Loading branch information
@HoonDongKang
HoonDongKang committed Sep 6, 2026
commit 5644cefd19d16c2b7cb16c63d68243378edbca80
4 changes: 3 additions & 1 deletion lib/internal/cli_table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,10 @@ const table = (head, columns) => {
ArrayPrototypeJoin(divider, tableChars.rowMiddle) +
tableChars.rightMiddle + '\n';

for (const row of rows)
for (let i = 0; i < rows.length; i++) {
const row = rows[i];
result += `${renderRow(row, columnWidths)}\n`;
}

result += tableChars.bottomLeft +
ArrayPrototypeJoin(divider, tableChars.bottomMiddle) +
Expand Down
Loading