Skip to content

quic: changes for nghttp3_conn_close_stream2 #64574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 6 commits into from
Aug 23, 2026
Merged

quic: changes for nghttp3_conn_close_stream2 #64574

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a3a5377
quic: changes for nghttp3_conn_close_stream2
martenrichter Jul 18, 2026
0dc69dd
quic: fix lint
martenrichter Jul 18, 2026
0d8acbe
quic: Fix lint in src/quic/http3.cc
martenrichter Jul 20, 2026
1a8bf05
quic: Fix OnStreamClose
martenrichter Aug 8, 2026
d1288af
quic: fix lint
martenrichter Aug 9, 2026
6875095
quic: fix lint
martenrichter Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
quic: fix lint
  • Loading branch information
@martenrichter
martenrichter committed Aug 9, 2026
commit 68750950bcc54045dec8e1b8bbb5121fd7e1b3de
11 changes: 6 additions & 5 deletions src/quic/http3.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,11 +503,12 @@ class Http3ApplicationImpl final : public Session::Application {
code = error.code();
}

int rv = nghttp3_conn_close_stream2(*this,
NGHTTP3_STREAM_CLOSE_FLAG_RX_APP_ERROR_CODE_SET,
stream->id(),
code,
0);
int rv = nghttp3_conn_close_stream2(
*this,
NGHTTP3_STREAM_CLOSE_FLAG_RX_APP_ERROR_CODE_SET,
stream->id(),
code,
0);
// If the call is successful, Http3Application::OnStreamClose callback will
// be invoked when the stream is ready to be closed. We'll handle destroying
// the actual Stream object there.
Expand Down
Loading