docs: added a License#36278
Conversation
aduh95
left a comment
There was a problem hiding this comment.
Our license file is https://github.com/nodejs/node/blob/master/LICENSE. I don't think there is any value to have that information in the README.
Trott
left a comment
There was a problem hiding this comment.
"License" would need to be added to the table of contents around line 24 if we do it this way.
Can we maybe move this further down in the document? Maybe after "Contributing to Node.js" and before "Current Project Team Members"? Or maybe even all the way at the bottom of the document?
By the way, if you prefer that I add a fixup commit to make these changes rather than implementing them yourself, let me know. I know it can be tedious when a small change like this gets a bunch of requests for changes. |
|
Can you move it above the definitions to fix the linter issue please? |
Sure. |
|
I think this is almost ready, there is just one point left:
|
There was a problem hiding this comment.
This should link to the LICENSE file instead.
There was a problem hiding this comment.
The license file is linked just below, are you suggesting to also remove the See LICENSE for the full license text sentence?
There was a problem hiding this comment.
ping @jasnell I think this is the last thing we need to clarify before this can land.
There was a problem hiding this comment.
Yes, removing the last sentence and moving the link to the LICENSE file should work.
There was a problem hiding this comment.
@jasnell sorry I missed your comment before landing, do you want me to revert?
|
No need to fix it in the PR but here's a commit message nit-pick for whoever lands this: The first word after the subsystem should be an imperative mood verb. So |
Thank you. I will remember it. |
PR-URL: nodejs#36278 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
|
Landed in 91fe3de |
PR-URL: #36278 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #36278 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Added a License in README.md file.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes