Skip to content

child_process: escape args[] for shell #29576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Artoria2e5 wants to merge 21 commits into from
Closed

child_process: escape args[] for shell #29576

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
ba9d9f3
child_process: escape args[] for shell
Artoria2e5 Sep 12, 2019
fe443d2
child_process: improve escape on cmd and docs
Artoria2e5 Sep 20, 2019
0d8de7d
child_process: make escaping opt-in with shellEscape
Artoria2e5 Sep 20, 2019
242ecd9
child_process: document Cygwin/MSYS, one case when you MUST go verbatim
Artoria2e5 Oct 8, 2019
d75fe07
doc: add big flashing bolded <marquee> security warning
Artoria2e5 Oct 21, 2019
a01ac85
Apply suggestions from code review [fixme]
Artoria2e5 Oct 24, 2020
0ccc509
Apply more suggestions from code review
Artoria2e5 Oct 25, 2020
240fddf
child_process.md: link ordering (incomplete)
Artoria2e5 Oct 25, 2020
a0c791a
js: fixup for suggestion
Artoria2e5 Oct 25, 2020
551417b
really fix the link ordering
Artoria2e5 Nov 7, 2020
68018aa
LINT GOD PLEASE ACCEPT MY OFFERING
Artoria2e5 Nov 7, 2020
d66746c
Allow custom escapers
Artoria2e5 Nov 9, 2020
19c2125
testWindowsExe should always trigger on win32
Artoria2e5 Nov 9, 2020
1e54c83
doc
Artoria2e5 Nov 9, 2020
5821e0a
remove irrlevant comment
Artoria2e5 Nov 12, 2020
cdae7ff
add node for cmd arg
Artoria2e5 Nov 12, 2020
770d59a
validate for lack of newline in quoteCmdArg
Artoria2e5 Nov 12, 2020
46d190b
Appease the linter god
Artoria2e5 Jan 11, 2021
804a346
fix duplicate import
Artoria2e5 Jan 12, 2021
0dfba45
Apply suggestions from code review
Artoria2e5 May 7, 2021
c0a6aff
Merge branch 'master' into fix!/child-process-args
Artoria2e5 May 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Appease the linter god
  • Loading branch information
@Artoria2e5
Artoria2e5 committed Jan 11, 2021
commit 46d190b59ff691e37cd3a7e7920597c355b31c69
2 changes: 1 addition & 1 deletion lib/child_process.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,7 +842,7 @@ function quoteCmdArg(arg) {
// Batch files have differences in that cmd double-interprets the string,
// but that should not affect us as the result is simply inert to CMD here.
// cf. https://daviddeley.com/autohotkey/parameters/parameters.htm#BATCH
if (arg.indexOf('\n') != -1 || arg.indexOf('\r') != -1) {
if (arg.indexOf('\n') !== -1 || arg.indexOf('\r') !== -1) {
Comment thread
Artoria2e5 marked this conversation as resolved.
Resolved
throw new ERR_INVALID_ARG_VALUE(`arg`, arg,
Comment thread
Artoria2e5 marked this conversation as resolved.
Resolved
'cannot contain newlines for cmd');
}
Expand Down