Skip to content

doc: fix max length on stream.md#19169

Closed
mcollina wants to merge 1 commit into
nodejs:masterfrom
mcollina:fix-markdown-linting-stream
Closed

doc: fix max length on stream.md#19169
mcollina wants to merge 1 commit into
nodejs:masterfrom
mcollina:fix-markdown-linting-stream

Conversation

@mcollina

@mcollina mcollina commented Mar 6, 2018

Copy link
Copy Markdown
Member

See: #18438

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@mcollina mcollina added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 72 hours to land. labels Mar 6, 2018
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Mar 6, 2018
@joyeecheung

joyeecheung commented Mar 6, 2018

Copy link
Copy Markdown
Member

Linter CI: https://ci.nodejs.org/job/node-test-pull-request-lite/225/

@mcollina

mcollina commented Mar 6, 2018

Copy link
Copy Markdown
Member Author

LINT CI: https://ci.nodejs.org/job/node-test-linter/16732/

@joyeecheung

joyeecheung commented Mar 6, 2018

Copy link
Copy Markdown
Member

CI is green

@mcollina

mcollina commented Mar 6, 2018

Copy link
Copy Markdown
Member Author

landing

@mcollina

mcollina commented Mar 6, 2018

Copy link
Copy Markdown
Member Author

Landed in 1a5ec83

@mcollina mcollina closed this Mar 6, 2018
@mcollina mcollina deleted the fix-markdown-linting-stream branch March 6, 2018 13:52
mcollina added a commit that referenced this pull request Mar 6, 2018
@mcollina
doc: fix max length on stream.md
1a5ec83 
See: #18438

PR-URL: #19169
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@mcollina @MayaLekova
doc: fix max length on stream.md
adc9ba4 
See: nodejs#18438

PR-URL: nodejs#19169
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 72 hours to land. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mcollina @joyeecheung @BridgeAR @nodejs-github-bot