pangram: add tests for alphabetical min/max (exercism#2192)

cmccandless · web-flow · commit db5f03c16882 · 2020-03-19T14:40:24.000Z
Resolves exercism#2190 Signed-off-by: Corey McCandless <corey.mccandless@atlasied.com>
diff --git a/exercises/pangram/.meta/additional_tests.json b/exercises/pangram/.meta/additional_tests.json
@@ -0,0 +1,20 @@
+{
+  "cases": [
+    {
+      "description": "sentence without lower bound",
+      "property": "isPangram",
+      "input": {
+        "sentence": "bcdefghijklmnopqrstuvwxyz"
+      },
+      "expected": false
+    },
+    {
+      "description": "sentence without upper bound",
+      "property": "isPangram",
+      "input": {
+        "sentence": "abcdefghijklmnopqrstuvwxy"
+      },
+      "expected": false
+    }
+  ]
+}
diff --git a/exercises/pangram/.meta/template.j2 b/exercises/pangram/.meta/template.j2
@@ -1,14 +1,25 @@
 {%- import "generator_macros.j2" as macros with context -%}
-{{ macros.header() }}
-
-class {{ exercise | camel_case }}Test(unittest.TestCase):
-    {# All test cases in this exercise are nested, so use two for loops -#}
-    {% for case in cases -%}
+{% macro test_case(case) -%}
+    {%- set input = case["input"] -%}
     def test_{{ case["description"] | to_snake }}(self):
         self.assertIs(
             {{ case["property"] | to_snake }}("{{ case["input"]["sentence"].replace('"', '\\"') }}"),
             {{ case["expected"] }}
         )
+{%- endmacro %}
+{{ macros.header()}}
+
+class {{ exercise | camel_case }}Test(unittest.TestCase):
+    {# All test cases in this exercise are nested, so use two for loops -#}
+    {% for case in cases -%}
+    {{ test_case(case) }}
     {% endfor %}
+    {% if additional_cases | length -%}
 
+    # Additional tests for this track
+
+    {% for case in additional_cases -%}
+    {{ test_case(case) }}
+    {% endfor %}
+    {%- endif %}
 {{ macros.footer() }}
diff --git a/exercises/pangram/pangram_test.py b/exercises/pangram/pangram_test.py
@@ -41,6 +41,14 @@ def test_mixed_case_and_punctuation(self):
     def test_case_insensitive(self):
         self.assertIs(is_pangram("the quick brown fox jumps over with lazy FX"), False)
 
+    # Additional tests for this track
+
+    def test_sentence_without_lower_bound(self):
+        self.assertIs(is_pangram("bcdefghijklmnopqrstuvwxyz"), False)
+
+    def test_sentence_without_upper_bound(self):
+        self.assertIs(is_pangram("abcdefghijklmnopqrstuvwxy"), False)
+
 
 if __name__ == "__main__":
     unittest.main()
