Repository navigation
Improve specrum visulaizer for transparent backgrounds - #467
Merged
Merged
Conversation
Collaborator
Contributor
Author
|
I guess that depends on the font and renderer, on termux (Android app) he whole visualizer looks bad. Maybe try another font (font config should also be able to only replace the legacy computing chars)? |
|
Is there any reason this wasn't merged beside the author's typos? It's behind an option, as far as I can tell, and fixes (in some cases) an ugly hack in the visualizer; and if it doesn't, just disable it. It merged to master without issue for me, and works great with my font. Does no one else want this feature? |
Contributor
Author
Collaborator
|
Looks like this works fine in konsole now, so let's merge. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I replaced the previous flipping method with chars I found in Symbols for Legacy Computing. This improves the spectrum visualizer when viewed in a terminal with a transparent background.
old:


new:
(Both tested in kitty)