Skip to content

Improve specrum visulaizer for transparent backgrounds - #467

Merged
arybczak merged 3 commits into
ncmpcpp:masterfrom
TilCreator:improve_flipped_specrum
Aug 21, 2024
Merged

arybczak merged 3 commits into
ncmpcpp:masterfrom
TilCreator:improve_flipped_specrum

Conversation

@TilCreator

Copy link
Copy Markdown
Contributor

I replaced the previous flipping method with chars I found in Symbols for Legacy Computing. This improves the spectrum visualizer when viewed in a terminal with a transparent background.

old:
screenshot_1617751540
new:
screenshot_1617751531
(Both tested in kitty)

@arybczak

arybczak commented Apr 8, 2021

Copy link
Copy Markdown
Collaborator

Thanks. Sadly, that doesn't seem to look good in my terminal (konsole) :(

Screenshot_20210408_225258

@TilCreator

Copy link
Copy Markdown
Contributor Author

I guess that depends on the font and renderer, on termux (Android app) he whole visualizer looks bad. Maybe try another font (font config should also be able to only replace the legacy computing chars)?
I will add a config option to enable / disable the legacy chars with an appropriate "warning", should it be enabled or disabled by default?

@coothon

coothon commented Apr 19, 2023

Copy link
Copy Markdown

Is there any reason this wasn't merged beside the author's typos? It's behind an option, as far as I can tell, and fixes (in some cases) an ugly hack in the visualizer; and if it doesn't, just disable it.

It merged to master without issue for me, and works great with my font. Does no one else want this feature?

@TilCreator

Copy link
Copy Markdown
Contributor Author

I should maybe fix the typos ^^

I'm using #467 and #482 on the newest release for as long as I wrote them without issue.

@arybczak

Copy link
Copy Markdown
Collaborator

Looks like this works fine in konsole now, so let's merge. Thanks!

@arybczak
arybczak merged commit f83428a into ncmpcpp:master Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants