Canonicalising pack#1
Closed
stephenpascoe wants to merge 2 commits into
Closed
Conversation
Member
|
Thank you for your request. I agree on sorting dict key is a nice feature. But I afraid about there are no spec about "Canonical" msgpack. |
Member
|
Sorry, there is no conclusion about "Canonical" msgpack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to make canonicalised pack data to make suitable for hashing. I've noticed msgpack-perl already supports this. Would you consider this patch to allow sorting of dictionary keys during packing?
The code preserves the original logic as much as possible at the expense of repeating a for loop. This could be made more concise.
Also has a test. Although I can't get the tests running because "msgpack.packs" doesn't exist.