Improved performance of GridOut readline by creating readchunk method.#214
Closed
omus wants to merge 1 commit into
Closed
Improved performance of GridOut readline by creating readchunk method.#214omus wants to merge 1 commit into
omus wants to merge 1 commit into
Conversation
Previously readline would read one byte at a time using the read method. By reading one byte at a time we would be slicing the buffer over and over again causing readline to use more CPU than necessary.
Member
|
Thanks, we'll consider this. |
Member
|
Merged in 3649a3a, thanks for the patch. I found this improved the time for a random benchmark from 80 seconds to 2.5, and with some further optimizations the time dropped under a second. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously readline would read one byte at a time using the read
method. By reading one byte at a time we would be slicing the buffer
over and over again causing readline to use more CPU than necessary.