fix(domain/virtualhost): keep colons in --path-to-url values#1880
Merged
martin-helmich merged 1 commit intoJun 3, 2026
Merged
Conversation
The value of --path-to-url was split on every colon, so the URL portion after the protocol's "://" was dropped before the API call. The API then rejected the truncated string with "Target.Url: Does not match format 'uri'". Split on the first colon while preserving the rest of the value, matching the intent of the help text examples like "/:https://redirect.example".
martin-helmich
approved these changes
Jun 3, 2026
martin-helmich
left a comment
Member
There was a problem hiding this comment.
Ouch. 🤦♂️ Good catch, thanks. 👍
mittwald-machine
added a commit
that referenced
this pull request
Jun 3, 2026
## [1.17.2](v1.17.1...v1.17.2) (2026-06-03) ### Bug Fixes * **domain/virtualhost:** keep colons in --path-to-url values ([#1880](#1880)) ([2e30d12](2e30d12))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1879.
--path-to-url "/:https://example.com"currently fails withTarget.Url: Does not match format 'uri'because the value is split on every colon, sourlends up as"https".This change splits on the first colon while preserving the rest:
split(":", 2)would not work in JS — it drops the rest of the string. The destructure +joinapproach keeps the full URL, including any colons inside it (e.g. ports:https://backend.example.com:8080/v2).Verification
yarn compile,yarn lint, prettier — all green.yarn test:unit(full suite): 121 tests passing, no regressions.No new unit test added — this command does not currently have unit-test coverage and the parsing is inline in
exec(). Happy to extract a helper and add a test if maintainers prefer.