Repository navigation
Default new cloud automations to no allowed tools - #342481
Merged
Ben Villalobos (benvillalobos) merged 2 commits intoOct 19, 2026
Merged
Ben Villalobos (benvillalobos) merged 2 commits into
Ben Villalobos (benvillalobos) merged 2 commits into
Conversation
Preserve saved tool selections while initializing new cloud automations with an explicit empty tool list. Remove catalog-dependent default selection and update dialog regression coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: dcf7492a-57a5-4314-a573-5c75a21d1c5a
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
No actionable defects were identified, but regression tests and manual UI validation remain unverified.
No open issues 🎉
What changed in this PR
Changes the Agents window automation dialog so new cloud automations default to no allowed tools.
Changes:
- Saves an explicit empty tool list without waiting for the catalog.
- Preserves existing tool selections and unreported configurations when editing.
- Updates regression coverage for selection labels, accessibility counts, and catalog states.
| File | Description |
|---|---|
| src/vs/sessions/contrib/automations/test/browser/automationDialog.test.ts | Updates selection expectations and tests saving across catalog states. |
| src/vs/sessions/contrib/automations/browser/automationDialog.ts | Defaults new selections to empty and removes catalog-dependent saving. |
Review effort: Balanced
Ben Villalobos (benvillalobos)
approved these changes
Oct 19, 2026
Anthony Kim (anthonykim1)
approved these changes
Oct 19, 2026
Ben Villalobos (benvillalobos)
enabled auto-merge (squash)
October 19, 2026 16:49
Giuseppe Cianci (Giuspepe)
approved these changes
Oct 19, 2026
Ben Villalobos (benvillalobos)
merged commit Oct 19, 2026
50d1fca
into
microsoft:main
49 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New cloud automations now start with no allowed tools instead of selecting every tool in the catalog. Saving sends an explicit empty tools array without waiting for catalog loading. Editing or duplicating an automation preserves its saved tool selection, and edits with unreported tools preserve the existing configuration.
Updated dialog regression coverage for the default selection, selection labels and accessibility counts, explicit tool selection, and saving with ready, empty, loading, or unavailable tool catalogs.
No linked issue; requested as a default-behavior change.
How to test
In the Agents window, open Customizations → Automations → Create Automation, turn on Run in the cloud, and choose a repository. Verify that the tools control shows zero tools allowed and the picker starts with every tool unchecked. Create an automation without changing tools, then verify its saved tool list is empty. Explicitly select tools and confirm those selections save; edit or duplicate an existing automation and confirm its saved selections remain selected.
Validation
git diff --check— passed.npm run build-fast -- --client-only— failed because theesbuilddependency is missing../scripts/test.sh --run src/vs/sessions/contrib/automations/test/browser/automationDialog.test.ts --reporter dot— not run because the preceding client build failed.npm run eslint -- src/vs/sessions/contrib/automations/browser/automationDialog.ts src/vs/sessions/contrib/automations/test/browser/automationDialog.test.ts— failed because theeslintdependency is missing.npm run install-fast— failed withEALLOWSCRIPTS(project-scoped--allow-scriptsis rejected), blocking dependency restoration.Manual UI validation was not performed.