Fix quota trajectory billing period calculation#325895
Merged
pwang347 merged 4 commits intoJul 15, 2026
Merged
Conversation
Compute elapsed usage from one calendar month before the reset date instead of assuming every billing period is 30 days. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: aa202495-3a47-4b52-896f-3862c69efd9e
Contributor
There was a problem hiding this comment.
Pull request overview
Corrects quota trajectory calculations to use the prior calendar month rather than a fixed 30-day period.
Changes:
- Derives and clamps the billing-period start from the reset date.
- Adds deterministic 31-day-cycle coverage.
Show a summary per file
| File | Description |
|---|---|
chatQuotaNotification.ts |
Updates billing-period calculation. |
chatQuotaNotification.test.ts |
Stabilizes time and covers a 31-day cycle. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Medium
Cover March 31 resets in non-leap and leap years so the previous-month day clamp is exercised. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: aa202495-3a47-4b52-896f-3862c69efd9e
rfeltis
commented
Jul 15, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: aa202495-3a47-4b52-896f-3862c69efd9e
rfeltis
commented
Jul 15, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: aa202495-3a47-4b52-896f-3862c69efd9e
rfeltis
marked this pull request as ready for review
July 15, 2026 17:42
pwang347
approved these changes
Jul 15, 2026
pwang347
enabled auto-merge (squash)
July 15, 2026 18:09
sandy081
approved these changes
Jul 15, 2026
roblourens
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
npm run typecheck-clientFollow-up to #320683.