Skip to content

Handle voice barge-in playback#325808

Merged
meganrogge merged 1 commit into
microsoft:mainfrom
mirimadahmed:handle-voice-barge-in
Jul 14, 2026
Merged

Handle voice barge-in playback#325808
meganrogge merged 1 commit into
microsoft:mainfrom
mirimadahmed:handle-voice-barge-in

Conversation

@mirimadahmed

@mirimadahmed mirimadahmed commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No description provided.

Mir Imad Ahmed
Handle voice barge-in playback
25fa357 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: ca429481-7dae-4a10-bef0-fad6056dc8ea
Copilot AI review requested due to automatic review settings July 14, 2026 14:56
@mirimadahmed

mirimadahmed commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@mirimadahmed

mirimadahmed commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

@mirimadahmed please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Copilot AI reviewed Jul 14, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds backend-driven voice barge-in handling to interrupt assistant playback.

Changes:

  • Introduces and emits a typed barge_in event.
  • Interrupts queued and active assistant audio.
  • Adds WebSocket event-mapping coverage.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
voiceClientService.test.ts Tests barge-in event parsing.
common/voiceClientService.ts Defines the barge-in API.
voiceSessionController.ts Interrupts playback on barge-in.
browser/voiceClientService.ts Maps backend messages to events.

Comment thread src/vs/workbench/contrib/chat/browser/voiceClient/voiceSessionController.ts
@meganrogge
meganrogge enabled auto-merge (squash) July 14, 2026 16:32
@meganrogge
meganrogge merged commit 8d44b55 into microsoft:main Jul 14, 2026
29 checks passed
@vs-code-engineering vs-code-engineering Bot added this to the 1.130.0 milestone Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@roblourens roblourens roblourens approved these changes
@amunger amunger amunger approved these changes
@meganrogge meganrogge meganrogge approved these changes

Assignees

@meganrogge meganrogge

Labels

None yet

Projects

None yet

Milestone

1.130.0

Development

Successfully merging this pull request may close these issues.

5 participants

@mirimadahmed @roblourens @amunger @meganrogge