Make code-review composable and add a architecture/design axis #515
OmerGronich
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
I have two related suggestions for
/code-review.1. Add architecture/design as a third review axis
The current skill reviews changes along two independent axes:
I think there is a third question worth reviewing independently:
A change can satisfy both the spec and the repository's coding standards while still making the codebase harder to maintain.
For example, it might:
These are not necessarily spec violations or coding-standard violations. They are design concerns.
Since the existing
codebase-designskill already defines principles and shared vocabulary for evaluating these decisions, could/code-reviewuse it as the basis for a separate Design or Architecture axis?Keeping it separate would also preserve the reasoning behind the current two-axis structure: a design concern should not be presented as a coding-standard violation, and strong design should not hide a spec failure.
The result would be three independently reported perspectives:
2. Extract Spec and Standards verification into independently invocable skills
I also think the existing Spec and Standards axes would be useful as standalone skills rather than only as internal parts of
/code-review.I often want to invoke them independently.
For example, when reviewing legacy code that has already been merged, verified, and running in production, there may be no useful originating spec to validate. I still want to review the code against the repository's coding standards and smell baseline without running the full
/code-reviewworkflow.The reverse can also be useful. Sometimes I only want to verify an implementation against a spec without requesting a broader code-quality review.
Could the individual review axes become independently invocable skills, with
/code-reviewacting as the orchestrator?Conceptually:
Each skill could accept the same diff or fixed-point scope and produce its own report.
/code-reviewwould invoke all applicable reviews in parallel and aggregate their results, preserving its current behavior while making each capability reusable on its own.This would make the review model more composable:
/code-reviewfor a complete review of new work./review-specwhen correctness against requirements is the only concern./review-code-standardsfor legacy code, existing production code, or focused maintainability reviews.All reactions