Proposal: Unify "Done" Gating Standard for Skills #501
renjianguojinqianfan
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
I'm not a native English speaker, so the content below was summarized and translated with the help of AI — there may be some ambiguity or inaccuracies.
When using skills like
/tdd,/implement, and/code-review, I've noticed a recurring issue: the definition of "done" lacks a unified, checkable gating standard.Current State
/implementcomes closest to having a "hard gate" – it requires running tests, type checks, and code review. However, the specifics remain ambiguous:pytest,npm test,cargo test, or something else?These details are left to the AI's subjective judgment or the user's ad-hoc instructions, rather than being defined by the project itself.
Related discussions (e.g., #492) have also highlighted that a vague "done" definition can lead to the AI prematurely concluding tasks.
Proposal
Explore a lightweight convention for "done" gating that skills can detect and follow:
Define a unified verification entry point – for example,
make verifyor./scripts/verify.sh– that bundles linting, testing, type checking, and coverage into a single command. Skills would check for the existence of such an entry point and treat its successful run as a hard prerequisite for "done."Maintain backward compatibility – projects without such a convention remain unaffected; skills behave as they do today.
Follow the "checkable" principle – the completion criteria must be verifiable conditions, not vague descriptions.
Open Questions
Looking forward to your feedback.
All reactions