Skip to content

FIX: drop nonexistent nbconvert[execute] extra from dev dependencies - #32622

Merged
story645 merged 2 commits into
matplotlib:mainfrom
timhoffm:fix-environment-yml-nbconvert
Nov 20, 2026
Merged

story645 merged 2 commits into
matplotlib:mainfrom
timhoffm:fix-environment-yml-nbconvert

Conversation

@timhoffm

@timhoffm timhoffm commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

PR summary

conda 26 rejects pip-style extras in environment files, so
conda create -f environment.yml failed. nbconvert has no execute
extra (nbclient is a hard dependency), so the extra was a no-op anyway;
pip only warned about it. Remove it from both environment.yml and the
pyproject.toml dev dependency group.

AI Disclosure

Investigated and edited using Claude. I've checked the logic and that installing a dev environement works.

PR quality check

  • Use an expressive title, e.g. "Fix title font property precedence"
  • [N/A ] Plotting related features are demonstrated in an example
  • [N/A] New features and API changes have release notes
  • [N/A] Documentation complies with general and docstring guidelines

@timhoffm timhoffm added this to the v3.12.0 milestone Nov 18, 2026
conda 26 rejects pip-style extras in environment files, so
`conda create -f environment.yml` failed. nbconvert has no `execute`
extra (nbclient is a hard dependency), so the extra was a no-op anyway;
pip only warned about it. Remove it from both environment.yml and the
pyproject.toml dev dependency group.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@timhoffm
timhoffm force-pushed the fix-environment-yml-nbconvert branch from 4a9512d to 33cd2a9 Compare November 18, 2026 21:30
@github-actions github-actions Bot added the CI: Run cibuildwheel Run wheel building tests on a PR label Nov 18, 2026
@timhoffm timhoffm changed the title Fix environment.yml for conda >= 26: drop nonexistent nbconvert[execute] extra FIX: drop nonexistent nbconvert[execute] extra from dev dependencies Nov 18, 2026
@QuLogic

QuLogic commented Nov 19, 2026

Copy link
Copy Markdown
Member

The execute extra was dropped for nbconvert 6; should we add in a minimum requirement now?

@timhoffm

Copy link
Copy Markdown
Member Author

Good point. Let's add a min req.

We can either do:

  • nbconvert>=6.1,!=7.3.0,!=7.3.1 - v6.1 was released Jun 23, 2021; or
  • nbconvert>=7.4 - v7.4 was released May 8, 2023

For simplicity, I would go with the latter - 3.5 years should be old enough for a dev dependency.

Comment thread environment.yml Resolved
Comment thread pyproject.toml Resolved
Bump nbconvert min version to 7.4

This removes the need to exclude individual versions.
v7.4 was released May 8, 2023, which is old enough for a dev dependency.

Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
@story645
story645 merged commit e13f351 into matplotlib:main Nov 20, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: Run cibuildwheel Run wheel building tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants