Repository navigation
FIX: drop nonexistent nbconvert[execute] extra from dev dependencies - #32622
Merged
story645 merged 2 commits intoNov 20, 2026
Merged
Conversation
conda 26 rejects pip-style extras in environment files, so `conda create -f environment.yml` failed. nbconvert has no `execute` extra (nbclient is a hard dependency), so the extra was a no-op anyway; pip only warned about it. Remove it from both environment.yml and the pyproject.toml dev dependency group. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
timhoffm
force-pushed
the
fix-environment-yml-nbconvert
branch
from
November 18, 2026 21:30
4a9512d to
33cd2a9
Compare
jklymak
approved these changes
Nov 19, 2026
Member
|
The |
Member
Author
|
Good point. Let's add a min req. We can either do:
For simplicity, I would go with the latter - 3.5 years should be old enough for a dev dependency. |
timhoffm
commented
Nov 19, 2026
timhoffm
commented
Nov 19, 2026
Bump nbconvert min version to 7.4 This removes the need to exclude individual versions. v7.4 was released May 8, 2023, which is old enough for a dev dependency. Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
story645
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
conda 26 rejects pip-style extras in environment files, so
conda create -f environment.ymlfailed. nbconvert has noexecuteextra (nbclient is a hard dependency), so the extra was a no-op anyway;
pip only warned about it. Remove it from both environment.yml and the
pyproject.toml dev dependency group.
AI Disclosure
Investigated and edited using Claude. I've checked the logic and that installing a dev environement works.
PR quality check