Skip to content

Notify slider observers before redrawing in set_val - #32587

Open
huzaifarahman13 wants to merge 1 commit into
matplotlib:mainfrom
huzaifarahman13:fix-slider-set-val-order
Open

huzaifarahman13 wants to merge 1 commit into
matplotlib:mainfrom
huzaifarahman13:fix-slider-set-val-order

Conversation

@huzaifarahman13

@huzaifarahman13 huzaifarahman13 commented Nov 10, 2026 •

Copy link
Copy Markdown

PR summary

Closes #32526

Slider.set_val and RangeSlider.set_val called draw_idle() before notifying the on_changed observers. Because of that, the first redraw showed stale state for any artists that were updated inside the callback.
This PR moves the redraw so it happens after the observers are notified, in both methods. Behaviour with drawon=False is unchanged.
I added test_slider_set_val_notifies_before_draw, which checks that the callback runs before the draw for both sliders, with drawon set to True and False. It fails on main and passes with this change.

AI Disclosure

I used an AI assistant to help locate the code and draft the change and test. I reviewed and ran everything locally and understand the change.

PR quality check

  • Use an expressive title
  • New and changed code is tested
  • [N/A] Plotting related features are demonstrated in an example
  • [N/A] New features and API changes have release notes
  • [N/A] Documentation complies with general and docstring guidelines

@github-actions

Copy link
Copy Markdown

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks. We also ask that you please finish addressing any review comments on this PR and wait for it to be merged (or closed) before opening a new one, as it can be a valuable learning experience to go through the review process.

You can also join us on discourse chat for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide.
Please let us know if (and how) you use AI, it will help us give you better feedback on your PR.

We strive to be a welcoming and open project. Please follow our Code of Conduct.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Slider.set_val renders the figure before it notifies its observers, sometimes causing two renders per event

2 participants