Repository navigation
Move contour labeling methods into ContourSet - #32579
Open
sahilmathur254 wants to merge 3 commits into
Open
sahilmathur254 wants to merge 3 commits into
sahilmathur254 wants to merge 3 commits into
Conversation
sahilmathur254
marked this pull request as ready for review
November 7, 2026 07:40
timhoffm
approved these changes
Nov 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
ContourLabelerprovides labelling functionality solely forContourSet, yet the separate mixin complicates documentation and relies on attributes defined byContourSet. This PR consolidates the methods and type annotations withinContourSetand removes the mixin directly, following the maintainer’s guidance. Documentation and API removal notes are updated, with focused tests and before-and-after comparisons supporting preservation of existing labelling behaviour.Direct removal follows the maintainer’s confirmation.
Closes #31793.
AI Disclosure
Codex assisted with the code changes, regression coverage, and validation in isolated Docker environments. The PR description was also drafted with AI assistance, and this PR was submitted by Codex with the contributor’s explicit authorisation.
Local validation
use_clabeltext.Axes.clabel, and the removal note passed with warnings treated as errors. Links to unrelated guide pages were outside this focused check; the updated labeling links and method anchors were verified.The full test suite and full documentation site were not run locally. GitHub CI results are available in the PR checks.
PR quality check