Repository navigation
Conversation
…pybind-mplarray-initial
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Important
This PR depends on #32532 and will appear larger than it really is until #32532 is merged. To view the actual changes in this PR, compare pybind-mplarray-initial → pybind-mplbuffer.
This PR replaces our use of pybind11's
buffer_protocol()anddef_buffer()with our own functions. This is needed as nanobind does not provide a buffer protocol.For now, these functions will live in "py_buffer.h". In a future PR, there will be a variant that uses nanobind API and lives in some variant of: "mplutils.h", "mpl_buffer.h", or "mplbuffer.h". Both variants can exist as we adopt nanobind.
Usage
Replace
py::buffer_protocol()withpy::custom_type_setup(mpl::buffer_setup<TheClass>).The wrapped class needs to implement a
create_buffer_info()function which returns a newmpl::buffer_info:Use
set_owner()on theBufferInfoif anotherPyObjectowns the raw buffer:AI Disclosure
PR quality check