Repository navigation
Conversation
iccir
force-pushed
the
pybind-mplarray
branch
from
October 26, 2026 18:00
c417c91 to
4202b36
Compare
# Conflicts: # src/_path.h
2 tasks done
…pybind-mplarray # Conflicts: # lib/matplotlib/transforms.py # src/_path.h # src/_path_wrapper.cpp
2 tasks done
iccir
force-pushed
the
pybind-mplarray
branch
from
November 11, 2026 04:40
2ba2acb to
d643a58
Compare
iccir
marked this pull request as ready for review
November 14, 2026 03:44
iccir
marked this pull request as draft
November 14, 2026 03:44
iccir
force-pushed
the
pybind-mplarray
branch
from
November 14, 2026 04:00
26d4d06 to
691b7e8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Important
This PR depends on #32532 and will appear larger than it really is until #32532 is merged. I will rebase this pull request against "main" prior to marking it as "Ready for review".
This PR converts the remainder of our
py::arrayusage tompl::array.Naming Conventions
This PR attempts to make variable names and class member names consistent. We previously assigned "no suffix" to the pybind11
unchecked_referenceproxy objects. In this PR, I assigned "no suffix" tompl::arrayand use an_objsuffix for the raw incoming objects:mpl::defer<FooArray>orstd::optional<mpl::defer<…>>foo_objFooArrayfoofoo_arr.data()foo_dataTri Changes
Previously,
_tri.Triangulationused an empty tuple()to indicate a missingmask,edges, orneighborsparameter. This pull request changes the value used for "missing" to beNone. This makes the nanobind transition easier as we can avoidstd::variant.Not Changed
The following still use
py::arraydue to dtype specialization. They will eventually usenb::ndarray:_path.is_sorted_and_has_non_nan()_image.resample()AI Disclosure
PR quality check