Repository navigation
Conversation
|
Please rerun CI: I have no idea what's causing the failure |
|
⏰ This pull request might be automatically closed in two weeks from now. Thank you for your contribution to Matplotlib and for the effort you have put into this PR. This pull request does not yet meet the quality and clarity standards needed for an effective review. Project maintainers have limited time for code reviews, and our goal is to prioritize well-prepared contributions to keep Matplotlib maintainable. Matplotlib maintainers cannot provide one-to-one guidance on this PR. However, if you ask focused, well-researched questions, a community member may be willing to help. 💬 To increase the chance of a productive review:
As the author, you are responsible for driving this PR, which entails doing necessary background research as well as presenting its context and your thought process. If you are a new contributor, or do not know how to fulfill these requirements, we recommend that you familiarize yourself with Matplotlib's development conventions or engage with the community via our Discourse or one of our meetings before submitting code. If you substantially improve this PR within two weeks, leave a comment and a team member may remove the |
|
I do not know why the the AppVeyor stage is failing everywhere: https://ci.appveyor.com/project/matplotlib/matplotlib/builds/54613753 |
|
HI @clin1234 , you still haven't updated the PR description as requested. You should likely rebase for AppVeyor to pass here (see #32096 (comment)) |
| @@ -0,0 +1,103 @@ | |||
| # Stub generated from the C++ (pybind11) signatures in | |||
There was a problem hiding this comment.
I have a branch which adds a lot of typing to the backends, can we drop this file?
| def get_width_height(self) -> tuple[int, int]: ... | ||
| def load_char(self, charcode: CharacterCodeType, flags: LoadFlags = ...) -> Glyph: ... | ||
| def load_glyph(self, glyphindex: GlyphIndexType, flags: LoadFlags = ...) -> Glyph: ... | ||
| def load_glyph(self, glyph_index: GlyphIndexType, flags: LoadFlags = ...) -> Glyph: ... |
There was a problem hiding this comment.
How have these errors been escaping our testing?
|
Thank you for your interest in contributing to Matplotlib, but we cannot accept your contribution as this pull request does not meet our development standards. Following our review policy, we are closing this PR after allowing two weeks time for improvements. Thank you for your understanding. If you think your PR has been closed by mistake, please comment below. |
|
@melissawm @tacaswell ping |
|
We took a look at this, but with the on-going nano-bind work (which can auto-generate the pyi for the extension modules), #32624 which touches the backends, and the work going on the macos backend stubs, we decided to defer this until the other typing work in flight to land. I'm going to move this to draft for now. |
PR summary
Closes #31424. In particular:
draw_glyph_to_bitmapanddraw_glyphs_to_bitmaptake variable positional argsAI Disclosure
No AI was used.
PR quality check