Update timezone test to only use past dates#31780
Merged
Merged
Conversation
So British Columbia passed a law and our tests broke. BC no longer is going to observe DST, and so our test which used the 'Canada/Pacific' tz and tested dates going out ~200 years broke due to an [update](https://lists.iana.org/hyperkitty/list/tz-announce@iana.org/message/VX2Z3CBO6KHTYZNBBKFFWM7ZCI6TVCXP/) of the IANA Timezone database became off by an hour for future dates. This updates the test to only use past dates, spanning only 20 years instead of 200, but still tests that the tick no longer is the original date, as is expected.
Member
|
Just a small correction. BC plans to stay on Pacific daylight savings (UTC-7) and not switch to Pacific standard time (UTC-8). We will see how long it lasts when we are out of step with the rest of the west coast and it's still dark at 9:30 am in late December. |
scottshambaugh
approved these changes
May 30, 2026
jklymak
approved these changes
May 30, 2026
QuLogic
pushed a commit
that referenced
this pull request
May 30, 2026
QuLogic
added a commit
that referenced
this pull request
May 30, 2026
…780-on-v3.11.x Backport PR #31780 on branch v3.11.x (Update timezone test to only use past dates)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
So British Columbia passed a law and our tests broke. BC no longer is going to observe DST, and so our test which used the 'Canada/Pacific' tz and tested dates going out ~200 years broke due to an update of the IANA Timezone database became off by an hour for future dates.
This updates the test to only use past dates, spanning only 20 years instead of 200, but still tests that the tick no longer is the original date, as is expected.
Relevant XKCD:
AI Disclosure
None
PR checklist