Skip to content

Simplify shape-checking in QuadMesh.set_array. - #24829

Merged
QuLogic merged 1 commit into
matplotlib:mainfrom
anntzer:qms
Dec 29, 2022
Merged

QuLogic merged 1 commit into
matplotlib:mainfrom
anntzer:qms

Conversation

@anntzer

@anntzer anntzer commented Dec 28, 2022

Copy link
Copy Markdown
Contributor

This can be done now that the previously existing allowance for A having the wrong shape but right number of elements has been removed.

Also, raising ValueError in all cases is more consistent (#24356 (comment)).

PR Summary

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

This can be done now that the previously existing allowance for `A`
having the wrong shape but right number of elements has been removed.

Also, raising ValueError in all cases is more consistent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants