Skip to content

Expire QuadMesh old signature deprecation - #24356

Merged
ksunden merged 1 commit into
matplotlib:mainfrom
oscargus:quadmeshsignatureremoval
Nov 4, 2022
Merged

ksunden merged 1 commit into
matplotlib:mainfrom
oscargus:quadmeshsignatureremoval

Conversation

@oscargus

@oscargus oscargus commented Nov 3, 2022 •

Copy link
Copy Markdown
Member

PR Summary

Tests crash locally (they sometimes do), so will run the tests here and then add a release note.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@oscargus
oscargus force-pushed the quadmeshsignatureremoval branch from 8dc35d2 to 8407301 Compare November 3, 2022 21:49
f"{A.shape}")

if faulty_data:
raise TypeError(

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that this should be a ValueError?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@oscargus
oscargus force-pushed the quadmeshsignatureremoval branch from 8407301 to 091c7ce Compare November 3, 2022 21:53
@oscargus
oscargus marked this pull request as ready for review November 3, 2022 21:57
@oscargus oscargus added API: changes Changes to the public API, typically requiring deprecation. topic: collections and mappables labels Nov 3, 2022
@oscargus oscargus added this to the v3.7.0 milestone Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API: changes Changes to the public API, typically requiring deprecation. topic: collections and mappables

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants