Repository navigation
Text cleanups. - #18586
Merged
Merged
Text cleanups.#18586
Conversation
anntzer
force-pushed
the
textclean
branch
2 times, most recently
from
September 26, 2020 10:02
f0a7332 to
21105a0
Compare
Fix the docstring of _get_textbox. (`Text.get_extents` doesn't exist.) Inline `_draw_bbox` into its sole call site (the first half is the same as `update_bbox_position_size`; this does mean calling `convert_xunits/convert_yunits` twice but that should be cheap compared to everything else). `Annotation.draw` doesn't need to also call `update_bbox_position_size` as `Text.draw` will do it (I think the call was duplicated because the draw-a-bbox functionality was present in Annotation before it also moved to Text). rcParams -> mpl.rcParams. Remove an extraneous import.
timhoffm
approved these changes
Sep 26, 2020
dopplershift
approved these changes
Sep 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the docstring of _get_textbox. (
Text.get_extentsdoesn't exist.)Inline
_draw_bboxinto its sole call site (the first half is the sameas
update_bbox_position_size; this does mean callingconvert_xunits/convert_yunitstwice but that should be cheap comparedto everything else).
Annotation.drawdoesn't need to also callupdate_bbox_position_sizeas
Text.drawwill do it (I think the call was duplicated because thedraw-a-bbox functionality was present in Annotation before it also moved
to Text).
rcParams -> mpl.rcParams.
Remove an extraneous import.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).