Repository navigation
Restore build_alllocal.cmd - #15574
Closed
story645 wants to merge 3 commits into
Closed
Restore build_alllocal.cmd #15574story645 wants to merge 3 commits into
build_alllocal.cmd #15574story645 wants to merge 3 commits into
Conversation
anntzer
requested changes
Oct 30, 2019
anntzer
left a comment
Contributor
There was a problem hiding this comment.
This was made obsolete by #13077 (and even more by later files). Note that the latest docs do not mention it anymore: https://matplotlib.org/devdocs/users/installing.html#conda-packages.
Member
Author
|
Ugh, that probably should have been a commit message in the history explaining that... Also this is really making me think about docs & versioning and making that stuff more obvious in some way. |
Contributor
Member
Author
|
Once I rebased against master to include that PR it does just work and now I have a working from source native windows build and thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The building on windows using conda wheels instructions say to run
build_alllocal.cmdwhich git history suggests may have accidentally been deleted?commit 490687
I'm just adding the file back here in case it was accidental, otherwise this needs a doc fix that I don't know how to resolve.
ALso realizing now there's probably a git revert/cherry pick that's probably a better way of approaching this since it'll retain the file history.
xref w/ #15512 'cause that's how I ran into this.