Skip to content

FIX: don't check for interactive framework if none required - #12207

Merged
QuLogic merged 1 commit into
matplotlib:masterfrom
jklymak:fix-dont-check-framework-non-gui
Sep 23, 2018
Merged

QuLogic merged 1 commit into
matplotlib:masterfrom
jklymak:fix-dont-check-framework-non-gui

Conversation

@jklymak

@jklymak jklymak commented Sep 21, 2018 •

Copy link
Copy Markdown
Member

PR Summary

Closes #12188

Don't check the interactive framework if none is required...

Still tries the framework if a GUI is required, so pythons that pop up a GUI when the framework is started (i.e. OSX Framework builds) will pop up a gui when pyplot is imported.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer

anntzer commented Sep 22, 2018

Copy link
Copy Markdown
Contributor

Looks fine, though I have no idea whether that helps with the issue or not.

@jklymak

jklymak commented Sep 22, 2018

Copy link
Copy Markdown
Member Author

It stops instantiating macOSx framework if no framework is required.

@QuLogic
QuLogic merged commit 3d7922d into matplotlib:master Sep 23, 2018
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 23, 2018
dstansby added a commit that referenced this pull request Sep 23, 2018
…207-on-v3.0.x

Backport PR #12207 on branch v3.0.x (FIX: dont' check for interactive framework if none required)
@jklymak
jklymak deleted the fix-dont-check-framework-non-gui branch September 30, 2018 14:34
@QuLogic QuLogic changed the title FIX: dont' check for interactive framework if none required FIX: don't check for interactive framework if none required Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

matplotlib 3 pyplot on MacOS bounces rocket icon in dock

4 participants