You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've updated the logic in LogLocator to return ticks inside vmin, vmax in Make LogLocator only return one tick out of range #24436. I think this is fine, and fixes this issue, but will wait and see if there are any test failures.
Activity
dstansby commentedon Nov 30, 2022
To document where I've got with this:
LogLocatorfor returning lots of ticks outside the range ofvmin, vmaxwas added in Fix lost ticks #1686, to solve Drops last tick label for some ranges #1310. It looks like no tests were added in that PR for the original issue in Drops last tick label for some ranges #1310, and that issue seems unrelated toLogLocator.LogLocatorto return ticks insidevmin, vmaxin Make LogLocator only return one tick out of range #24436. I think this is fine, and fixes this issue, but will wait and see if there are any test failures.dstansby commentedon Dec 1, 2022
Sigh, sorry for the noise, I realise that
get_ticklocs()is documented to not return ticks within bounds.