You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is because the v3.3.x branch was not merged to master after the release. This would probably still be a problem now with setuptools-scm if that were not done, but it was done fairly quickly after 3.4.2, so is fine right now. However, since we use the post-release version scheme, you don't get is_devrelease == True.
On the call, we decided that it's probably a good idea to switch to this form for 3.5.0/master, but we don't have a strong preference. It would be best to confirm that this works for downstream libraries first. So this would change from:
- master : 3.4.2.post825+g303873fc65
- v3.4.x : 3.4.2+16.gdcfc7a17a2 <- Note this didn't use setuptools-scm, but would be a mix of these two things for the v3.5.x branch
to:
- master : 3.5.0.dev820+g6768ef8c4c.d20210520
- v3.4.x : 3.4.3.dev4+g97f47ba6d8.d20210520
This should always satisfy dev > stable for master, and I believe also version.is_devrelease.
Hello. Thanks for the replies! We don't really use is_devrelease attribute. I was just trying that out when > comparison didn't work. We usually use something like this in our tests. This is a very specific example but hopefully the idea comes across:
Activity
anntzer commentedon Feb 1, 2021
likely #18971 will fix that?
pllim commentedon Feb 1, 2021
I hope so!
QuLogic commentedon May 19, 2021
This is because the
v3.3.xbranch was not merged tomasterafter the release. This would probably still be a problem now withsetuptools-scmif that were not done, but it was done fairly quickly after 3.4.2, so is fine right now. However, since we use the post-release version scheme, you don't getis_devrelease == True.QuLogic commentedon May 19, 2021
We may want to switch to
release-branch-semver, which seems automatic while still closer to what we do compared to the defaultguess-next-dev.QuLogic commentedon May 20, 2021
On the call, we decided that it's probably a good idea to switch to this form for 3.5.0/master, but we don't have a strong preference. It would be best to confirm that this works for downstream libraries first. So this would change from:
-
master: 3.4.2.post825+g303873fc65-
v3.4.x: 3.4.2+16.gdcfc7a17a2 <- Note this didn't usesetuptools-scm, but would be a mix of these two things for thev3.5.xbranchto:
-
master: 3.5.0.dev820+g6768ef8c4c.d20210520-
v3.4.x: 3.4.3.dev4+g97f47ba6d8.d20210520This should always satisfy
dev > stableformaster, and I believe alsoversion.is_devrelease.Does that sound good for Astropy, @pllim?
pllim commentedon May 20, 2021
Hello. Thanks for the replies! We don't really use
is_devreleaseattribute. I was just trying that out when>comparison didn't work. We usually use something like this in our tests. This is a very specific example but hopefully the idea comes across:I think the new scheme will work nicely for us. Thanks! 🙇♀️