You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Switch to requiring Pillow rather than having our own png wrapper? #15165
#15160 reminded me that it's not always trivial to get C-level dependencies set up before building (though that specific issue is about freetype). We already vendor agg and qhull, and have an option to download freetype (via local_freetype/MPLLOCALFREETYPE), so the sole remaining dependency that always needs to be provided by the builder is libpng.
If we just depended (as an install_requires) on Pillow for png handling instead, we would be able to drop that dependency (together with a bunch of C code). Pillow has wheels for all three major OSes, supports PyPy, is actively developed, and has been around for a very long time.
Right now this is stuck on a few upstream issues (python-pillow/Pillow#3041, imageio/imageio#475); may end up needing to vendor some code from imageio with some more fixes to fix that.
On the other hand the (unpublished) draft patch I have does indeed make building on Windows much easier.
Activity
jklymak commentedon Aug 31, 2019
The idea seems reasonable. Is the performance at all dependent on the complexity of the plots, or the size of the pngs?
anntzer commentedon Sep 1, 2019
I don't have the numbers yet, but can set up more benchmarking.
tacaswell commentedon Sep 2, 2019
👍 if this is going to make both the build process simpler and get us a factor of 2 in writing.
anntzer commentedon Sep 2, 2019
in reading, not in writing.
tacaswell commentedon Sep 2, 2019
oh, derp, I apparently can not read, but even a small speed up, in conjunction with the easier install is still a win.
anntzer commentedon Sep 4, 2019
Right now this is stuck on a few upstream issues (python-pillow/Pillow#3041, imageio/imageio#475); may end up needing to vendor some code from imageio with some more fixes to fix that.
On the other hand the (unpublished) draft patch I have does indeed make building on Windows much easier.