limit specifying array indices to 20

nlf · nlf · commit 4667c41c586b · 2014-07-31T10:14:48.000-07:00
diff --git a/lib/parse.js b/lib/parse.js
@@ -46,7 +46,7 @@ internals.parseObject = function (chain, val) {
         obj = [];
         obj = obj.concat(internals.parseObject(chain, val));
     }
-    else if (!isNaN(index) && root !== cleanRoot) {
+    else if (!isNaN(index) && root !== cleanRoot && index <= 20) {
         obj = [];
         obj[index] = internals.parseObject(chain, val);
     }
diff --git a/test/parse.js b/test/parse.js
@@ -82,6 +82,13 @@ describe('Riddler.parse()', function () {
         done();
     });
 
+    it('limits specific array indices to 20', function (done) {
+
+        expect(Riddler.parse('a[20]=a')).to.deep.equal({ a: ['a'] });
+        expect(Riddler.parse('a[21]=a')).to.deep.equal({ a: { '21': 'a' } });
+        done();
+    });
+
     it('supports encoded = signs', function (done) {
 
         expect(Riddler.parse('he%3Dllo=th%3Dere')).to.deep.equal({ 'he=llo': 'th=ere' });
@@ -159,7 +166,7 @@ describe('Riddler.parse()', function () {
 
     it('should compact sparse arrays', function (done) {
 
-        expect(Riddler.parse('a[9999]=1&a[2]=2')).to.deep.equal({ a: ['2', '1'] });
+        expect(Riddler.parse('a[10]=1&a[2]=2')).to.deep.equal({ a: ['2', '1'] });
         done();
     });
 

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ internals.parseObject = function (chain, val) {`
`46`	`46`	`obj = [];`
`47`	`47`	`obj = obj.concat(internals.parseObject(chain, val));`
`48`	`48`	`}`
`49`		`- else if (!isNaN(index) && root !== cleanRoot) {`
	`49`	`+ else if (!isNaN(index) && root !== cleanRoot && index <= 20) {`
`50`	`50`	`obj = [];`
`51`	`51`	`obj[index] = internals.parseObject(chain, val);`
`52`	`52`	`}`