Repository navigation
Conversation
The 14.0 floor came only from the app plist: the VM APIs Kiri uses already exist in macOS 12, and the single macOS 13 API (VZLinuxRosettaDirectoryShare) is Apple-Silicon only. Lower the floor to 12.0, pin the binaries' minimum to 12.0 as well, and check the Rosetta class exists before calling availability().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes and why
Lowers Kiri's minimum macOS version from 14 to 12 (Monterey). The 14.0 floor came only from the app plist: the VM APIs Kiri uses already exist in macOS 12, and the single macOS 13 API (VZLinuxRosettaDirectoryShare) is Apple-Silicon only. The change lowers the floor to 12.0, pins the binaries' minimum to 12.0 as well, and checks the Rosetta class exists before calling availability(), so M1 Macs on Monterey don't touch a class that isn't there. Docs updated to macOS 12+.
Fixes #315 (Ventura is covered too: 12 < 13).
How you tested it
Tested on: macOS 12.7.6, Intel MacBookPro9,2 (13-inch, 2012)
Note on the 2 test failures: both are seccomp timing tests (
a_call_with_many_rules_compiles_in_linear_time_or_is_refused,a_profile_whose_libseccomp_tree_loops_compiles_quickly) that assert compilation under 50 ms; on this 2012 dual-core Mac they take 81–90 ms. I verified they fail the same way on unmodified main (pristine worktree), so they are pre-existing and unrelated to this change.How you found it
AI tools used to write this change: yes — an AI assistant helped write the code changes and this PR text; all testing was done by me on my real Mac.
Checklist
cargo fmt,cargo clippyand the tests pass